bpb27 / tta-elastic Goto Github PK

On the search page, the tips checkbox opens a modal route. Instead, this should be a side panel.

Done criteria:
[ ] checking the tips checkbox opens a side panel
[ ] side panel has a smooth entry animation
[ ] side panel works on mobile
[ ] uninstall react-router-modal

Hi!

The package specifies this project is ISC licensed.

Would you mind adding a license file with the corresponding copyright notice?

Would be nice to have a page for individual tweets that can be linked to, especially now that the original tweets no longer exist.

https://www.thetrumparchive.com/insights/insults and https://www.thetrumparchive.com/insights/past point to Twitter, and those tweets don't show up any more.

One workaround would be to use the same display from https://www.thetrumparchive.com/insights/past (which also seems affected by the ban).

A neat workaround would be to render the tweets very close to Twitter's UI, using @abraham's twitter-status component. Unlike all other Twitter React components, this one doesn't use Twitter's oembed, or fetch the tweet from Twitter. Instead it takes a parameter with the contents of the `GET statuses/show/:id response from Twitter, which can be recreated from the database.

Thanks for making this project! I noticed that the tweet identifiers in the JSON export have overflowed. This is a common problem when processing the tweet ids as integers instead of strings in JavaScript.

node --trace-deprecation node_modules\jest-cli\bin\jest server/tests/get-tweets.test.js
Expected results: should pass cleanly
Actual results: passes but points out that Buffer(...) is deprecated

(node:2820) [DEP0005] DeprecationWarning: Buffer() is deprecated due to security and usability issues. Please use the Buffer.alloc(), Buffer.allocUnsafe(), or Buffer.from() methods instead.
at showFlaggedDeprecation (buffer.js:194:11)
at new Buffer (buffer.js:281:3)
at getTweets ($REPO_ROOT\server\get-tweets.js:9:23)
at Object. ($REPO_ROOT\server\tests\get-tweets.test.js:9:5)
at $REPO_ROOT\node_modules\jest-jasmine2\build\queueRunner.js:43:12
at new Promise ()
at mapper ($REPO_ROOT\node_modules\jest-jasmine2\build\queueRunner.js:26:19)
at $REPO_ROOT\node_modules\jest-jasmine2\build\queueRunner.js:73:41
at processTicksAndRejections (internal/process/task_queues.js:93:5)
PASS server/tests/get-tweets.test.js

he's been unsuspended so not sure if you need to re-enable something to start pulling his tweets again...

If a tweet was posted after noon on UTC time, the CSV export script thinks it is posted 12 hours earlier than it actually was

The CSV export script also eats newlines, converts semicolons to commas, and converts ellipses to three periods