blond / eslint-config-pedant Goto Github PK

https://eslint.org/blog/2018/11/jsdoc-end-of-life

It is suggested to be replaced by https://github.com/gajus/eslint-plugin-jsdoc

http://eslint.org/docs/rules/no-useless-computed-key

http://eslint.org/docs/rules/no-unsafe-negation

Version 10 of Node.js (code name Dubnium) has been released! 🎊

To see what happens to your code in Node.js 10, Greenkeeper has created a branch with the following changes:

• Added the new Node.js version to your .travis.yml
• The new Node.js version is in-range for the engines in 1 of your package.json files, so that was left alone

If you’re interested in upgrading this repo to Node.js 10, you can open a PR with these changes. Please note that this issue is just intended as a friendly reminder and the PR as a possible starting point for getting your code running on Node.js 10.

Your Greenkeeper Bot 🌴

http://eslint.org/docs/rules/no-alert

This rule is important only for ES3:

This can cause problems with IE6/7 and IE9 if it's in quirksmode. Also, in some implementations of ES3 would add length to an array if it had an additional trailing comma. This was clarified in ES5 (source):

This was clarified in ES5 (source):

Edition 5 clarifies the fact that a trailing comma at the end of an ArrayInitialiser does not add to the length of the array. This is not a semantic change from Edition 3 but some implementations may have previously misinterpreted this.

For ES5 and ES2015 this rule is more stylistic. For, example, you may want to use trailing commas to cleaner git diffs:

// bad - git diff without trailing comma
const hero = {
     firstName: 'Florence',
-    lastName: 'Nightingale'
+    lastName: 'Nightingale',
+    inventorOf: ['coxcomb graph', 'modern nursing']
};

// good - git diff with trailing comma
const hero = {
     firstName: 'Florence',
     lastName: 'Nightingale',
+    inventorOf: ['coxcomb chart', 'modern nursing'],
};

I don't want to eslint-config-pedant limit your choice of code style.

Please provide some info on how to lint *.deps.js files with eslint-config-pedant as a base.

Add sub configs for different ES versions:

• es3
• es5
• es6

By default need provide es6.

{
  "extends": "pedant"
}

But user should be able choose es3 and es5:

{
  "extends": "pedant/es3"
}

yarn warns consumers with this warning, but it seems like it still works. perhaps we can loose the peerDeps range?

http://eslint.org/docs/rules/class-methods-use-this

http://eslint.org/docs/rules/no-extra-bind

Need replaced deprecated rules:

• no-native-reassign -> no-global-assign
• no-negated-in-lhs -> no-unsafe-negation

https://eslint.org/docs/rules/getter-return

I run the check with cli, and I see

error Parsing error: The keyword 'const' is reserved

by default the pedant must use the es2015 setting, but it gives an error on 'const'

why?

eslint and pedant installed globally
eslint v4.7.2
pedant v0.10.0

Add semantic versioning policy to README.md.

Add preset for examples in JsDoc and .md files.

This preset should consist of the same pedant rules without:

• no-new
• no-unused-expressions
• no-undef
• ???

For some cases need override Object methods.

Example:

class A {
    toString() {
        return '[MySuperObject]'; //  error  Expected 'this' to be used by class method 'toString'  class-methods-use-this
    }
}

I think need ignore next methods:

• toLocaleString
• toSource
• toString
• valueOf

what about allow to set trailing-comma in function calls/params and other places?

In es2015 trailing comma is ok in some places
see here https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Trailing_commas

I suggest to apply this rule in the default pedant config (not for es3, es5)

subj and pic

The eslint-config-pedant package does not provide knowledge about minimal required version of eslint.

https://eslint.org/docs/rules/accessor-pairs

http://eslint.org/docs/rules/no-useless-escape

http://eslint.org/docs/rules/block-scoped-var

падает с такой ошибкой:

./app/scripts/app.js
Module build failed: Error: pedant:
    Configuration for rule "no-dupe-args" is invalid:
    Value "error" is the wrong type.

...Referenced from .eslintrc

запускаю линтер через вебпаковый лоадер eslint-loader
в конфиге вебпака это выглядит как добавление лоадера вот такой строкой:

{
  test: /\.js$/,
  loader: 'eslint-loader',
  exclude: /node_modules/
}

и добавлением в массив плагинов вот этого

eslint: {
    configFile: path.join(__dirname, '.eslintrc'),
    emitErrors: false,
    emitWarning: true,
    formatter: eslintFormatter({notify})
}

версии:

$ cat package.json | grep eslint 
    "lint:scripts": "eslint app gulp",
    "babel-eslint": "^4.1.5",
    "eslint": "^1.9.0",
    "eslint-config-pedant": "^0.3.0",
    "eslint-loader": "^1.1.1",
    "eslint-config-pedant": "^0.3.0"

.eslintrc

env:
  browser: true
  es6: true
extends: pedant
parserOptions:
  ecmaVersion: 7
  sourceType: module

• я попробовал удалять глобальный eslint и устанавливать заново
  npm install --save-dev eslint-config-pedant
  (перед этим убрав его из package.json) но это не помогло.
  После этого возникает та же ошибка :(
• также попробовал установить педант более старой версии:
  npm install --save-dev [email protected]

тоже не помогло.

Сразу прошу прошения за многобукв и кажущуюся лень -- но я хз как на сайте eslint искать в какой версии еслинта у нас настройка "no-dupe-args" депрекейтнулась :(

Еси впадлу отвечать - свистни я закрою этот ишьюс

Now pedant will complain if parameter has no description.

/**
 * Evals file contents
 * @param {Function} callback
 * @param {Object} options
 * @returns {Object}
 */
function fileEval(file, options, callback) {
   /* ... */
}

For some parameters, such as callback or options the description is superfluous.

Need turn off requireParamDescription option.