v8/node deprecated APIs and how to handle them about bcrypto HOT 5 CLOSED

This issue seems to be getting a lot of attention from people in the community. Please note that Nan::To can be used in place of the nasty v8 syntax.

For example:

Nan::To<int32_t>(info[0]).FromJust()

Instead of:

info[0]->Int32Value(Nan::GetCurrentContext()).FromJust();

from bcrypto.

It looks like nan has upgraded for this, but only for strings: nodejs/nan@24a22c3

Corresponding PR: nodejs/nan#808

Nevermind, looks like it's still in the works: nodejs/nan#811

from bcrypto.

Finally fixed with 3a3bb28

from bcrypto.

Hi all,

In Node 8, I had:

v8::String::Utf8Value textV8(args[4]->ToString());
std::string           text(*textV8);

But in Node 12, with:

v8::Local<v8::String> textV8(args[4]->ToString(context).FromMaybe(v8::Local<v8::String>()));

I don't figure out how concert in std::string

Edit:
For the moment, I found this solution but too complicated for me:

v8::Local<v8::String> textV8(args[4]->ToString(context).FromMaybe(v8::Local<v8::String>()));
Nan::Utf8String       textNan(textV8);
std::string           text(*textNan);

from bcrypto.

marked

from bcrypto.