Git Product home page Git Product logo

Comments (5)

chjj avatar chjj commented on July 23, 2024

I can't seem to reproduce this with pkg. What bcrypto version are you using? Is there any chance of creating an isolated test case which reproduces the issue?

from bcrypto.

sdtsui avatar sdtsui commented on July 23, 2024

@chjj since this is for Bob, I think I can answer with reasonable confidence.

Here's our package-lock.json for Bob 4.0:

    "hsd": {
      "version": "https://github.com/kyokan/hsd/tarball/296f36c996d9e1561fd0718d9887402181d57c85",
      "integrity": "sha512-wrLgzlMnL/1vI5lwzR+FEfF9PUPXhuxPkxosFiekuDFHmkB2tvJQeETcS0w+mxLYBS8CFnQFfDyklczO74RCnw==",
      "requires": {
        "bcfg": "~0.1.6",
        "bcrypto": "bcrypto@git+https://github.com/bcoin-org/bcrypto.git#5c3e2b8b3f79d13e1b5c26be197708d0b9e5bcf9",
        "bdb": "~1.2.1",
        "bdns": "~0.1.5",
        "bevent": "~0.1.5",
        "bfile": "~0.2.2",
        "bfilter": "~1.0.5",
        "bheep": "~0.1.5",
        "binet": "~0.3.5",
        "blgr": "~0.1.7",
        "blru": "~0.1.6",
        "blst": "~0.1.5",
        "bmutex": "~0.1.6",
        "bns": "~0.11.0",
        "bsert": "~0.0.10",
        "bsock": "~0.1.9",
        "bsocks": "~0.2.5",
        "btcp": "~0.1.5",
        "buffer-map": "~0.0.7",
        "bufio": "~1.0.6",
        "bupnp": "~0.2.6",
        "bval": "~0.1.6",
        "bweb": "~0.1.10",
        "goosig": "git+https://github.com/kyokan/goosig.git#29cd9dce78abb296400104ab8fea62ee515cefc4",
        "hs-client": "~0.0.8",
        "n64": "~0.2.10",
        "urkel": "~0.6.3"
      },

This commit, from May 26th, is somewhere between 5.1 (may 19th) and 5.2 (jun 13th).

from bcrypto.

pinheadmz avatar pinheadmz commented on July 23, 2024

@chjj @mslipper I am able to get Bob to build and run in dev mode on Windows by reverting this commit: f8f5cb7 or in other words, using cmake instead of node-gyp as you're already planning on doing I think.

I'm not sure but reading up on this issue I think the problem is because electron doesn't contain nodejs, it runs a fork, and so there are these extra tools like electron-builder and electron-rebuild that have to compile the native addons for the correct javascript engine.

What I did just now is clone master branch of Bob, restore the hsd dependency to its master branch from handshake-org, remove the process.env.NODE_BACKEND = 'js' line and install. Then I removed node_modules/bcrypto and replaced it with the master branch of bcrypto, reverting that commit and rebuilding with cmake.

Bob seems to running fine on Windows now in dev mode, and synced the HNS blockchain in about 45 minutes.

from bcrypto.

chjj avatar chjj commented on July 23, 2024

@pinheadmz very interesting that it works with cmake. node-gyp adds a ton of unnecessary flags to each build (most of which are intended for building node.js itself, not addons). I would guess something here is borking the build on windows.

Maybe this justifies switching to cmake for everything, though it is an extra dependency for users depending on how you look at it.

from bcrypto.

pinheadmz avatar pinheadmz commented on July 23, 2024

Oh to be clear - hsd and bcrypto build fine on windows as-is master branches and latest releases. But there is something wrong with building for Electron on windows.

from bcrypto.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.