Comments (12)
@parham-k / @jwcodee - Could one of you please take a look at this?
from abyss.
from abyss.
Thanks for flagging this issue. We will be looking to implement a fix to address this issue.
from abyss.
@eli-schwartz can you see if https://github.com/bcgsc/abyss/tree/tlo addresses your issue?
from abyss.
There are 3 definitions:
- dialign/museq.c:
extern int simple_aligner
- dialign/assemble.c:
char simple_aligner
- Align/dialign.h:
char simple_aligner
It looks like your tree changes the second one from char to int, which means now the third is the odd one out.
from abyss.
I noticed that too, but I didn't see assemble.c including the dialign.h header so I didn't change the char there.
What parts of the build script did you add the following flags: -flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
?
from abyss.
I noticed that too, but I didn't see assemble.c including the dialign.h header so I didn't change the char there.
I don't think it has to? assemble.c has the (only) function implementation and that appears early on in the file before any actual uses.
What parts of the build script did you add the following flags:
-flto=4 -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing
?
It was exported before running configure, so it applies to all sources.
from abyss.
Keep in mind that what LTO is doing here is simply being a massively global optimization pass that is able to keep track of the entire linked program, including full type info, all at the same time. This means that it can double check that the symbol from assemble.c is compatible with the prototype in dialign.h and the additional prototype in museq.c
Since they are all referring to the same outputted machine code symbol anyway, they have to be compatible or the compiler might generate faulty code. Often, this passes silently if prototypes are incorrect. Due to the greatly expanded tracking capabilities afforded by the LTO optimizer, it is simply able to provide better diagnostics and uncover otherwise very hard to find issues.
from abyss.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your interest in ABySS!
from abyss.
Any updates on this, @jwcodee ?
from abyss.
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your interest in ABySS!
from abyss.
Any updates on this, @jwcodee?
from abyss.
Related Issues (20)
- contig histogram
- clarification re identity parameters HOT 2
- scaffolding with paired end short reads HOT 3
- abyss-overlap "Assertion `tend <= tseq.size' failed" HOT 7
- Highly Fragmented Assembly HOT 2
- Please add to README how to run tests HOT 4
- 'make check' fails: error: use of undeclared identifier 'EXPECT_DEATH' HOT 1
- Job using merged read pairs and unmerged read pairs gets killed HOT 5
- no abyss-pe.Makefile acess denied HOT 7
- Abyss 2.3.5 conda installed: pipeline stops at abyss-rresolver-short HOT 21
- Found conflicts looking for incompatible packages HOT 3
- run in conda HOT 3
- Build failure on macOS 12 and 13 HOT 9
- Build failure on Arch linux HOT 34
- Assertion failed HOT 13
- Error - terminate called after throwing an instance of 'std::length_error' HOT 4
- Install AbySS with conda HOT 4
- Abyss - error Makefile:667 HOT 5
- Empty contig files despite stats looking OK HOT 11
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abyss.