Git Product home page Git Product logo

Comments (1)

czekan avatar czekan commented on July 20, 2024

The reasonable solution is to return ThirdPartyFailure (and other exceptions that inherit from VelruseException) than raise it.
Than we could register view in our application which will handle the errors the same way we handle AuthenticationComplete and AuthenticationDenied. Eg.:

@view_config(
    context='velruse.exceptions.VelruseException',
    renderer='app:templates/social_login_error.html',
)
def login_error_view(request):
    # do something with it, eg. redirect to home and flash message
    error = request.context.message
    request.session.flash({'type': 'danger', 'messages': [error, ]})
    log.warning(request.context)
    return HTTPFound(location=request.route_url('home'))

We've got fork of forked repo :)(with linkedin_oauth2 support), which includes those changes:
https://github.com/codersmill/velruse/tree/feature/handling_errors

I can prepare proper Pull Request if maintainer accept this solution.

from velruse.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.