Before and after login events about velruse HOT 3 OPEN

Great idea. I wouldn't subclass from NewRequest though. Is there a reason you did that? Events can be any object.

from velruse.

I used NewRequest because it was an easy and document way to get the request in the event object without creating/recreating an event class, but an easy enough thing to change.

Sounds like you're in favor of the feature. Anything you have concerns about? If not, I'll put it together for the various provider classes and submit a pull request.

from velruse.

The feature is good but I think instead of separate subclasses for each provider I will just use a subscriber predicate based on the name of the provider. I've been pondering it as a better way of doing the authentication subclasses as well. I'm thinking something like:

@subscriber('velruse.BeforeLogin', provider_name='google')
def google_login_attempt(event):
    # ...

I'm not sure what to call the PendingLogin event, emitted after the redirect. That one may not be useful?

from velruse.