Comments (6)
keul
commented on July 20, 2024
@MLR-au We are working on the same issue for linkedin (see our branch at https://github.com/RedTurtle/velruse) but we don't use verifiedEmail (because it's not verified) but the Portable Contacts standard emails.
from velruse.
marcolarosa
commented on July 20, 2024
Sure - I don't have an issue with that. I was just following what was in the google_oauth2 provider. I must admit,
I didn't look up the linkedin api docs to see if the email is verified or not.
From my point of view, if we could depend on 'emails' being consistent across all providers that would be nice.
from velruse.
mmerickel
commented on July 20, 2024
I will look into this. I've been trying to standardize the "emails" list in the profile as I go through things this last week. I don't have a linkedin account atm, but if someone wants to add a test for linked in "tests/selenium/tests.py" I'd be happy to merge it. Without the test you'll have to wait for me to take care of things. :-)
from velruse.
keul
commented on July 20, 2024
@mmerickel I can try to look at this also.
from velruse.
keul
commented on July 20, 2024
See #121
from velruse.
mmerickel
commented on July 20, 2024
#121 and 93fecec should take care of these issues.
from velruse.
Related Issues (20)
- Error in OpenId connection HOT 2
- Wrong authentication complete class for OpenID HOT 3
- Google_oauth2 failure
- Before and after login events HOT 3
- data['email'] raises KeyError with velruse.google.scope = 'opend profile' HOT 2
- Recent Twitter error -- data['utc_offset'] float conversion. HOT 2
- Missing make_velruse_app function HOT 1
- Review routes for bitbucket
- is it better not to extract resp from proivder in callback()?
- Problems after linkedin provider migrated to oauthlib HOT 1
- Valid exceptions during provider login causes unrecoverable exception
- ThirdPartyFailure is raised when something gows wrong with provider, but there's no way to catch it. HOT 1
- Window's Live ID authentication isn't working
- Google is deprecating and shutting down OpenID support
- Can Velruse work with Traversal route HOT 1
- Link in repo description redirects
- Facebook Login is broken: KeyError: 'access_token' HOT 4
- FB Oauth2 URL has changed HOT 1
- Live OAuth URLs have changed.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from velruse.