Git Product home page Git Product logo

linter-docker's Introduction

AtomLinter Website

Adding a Linter Provider

Made a linter provider? Great! We'd love to include it in our list! Just follow this step-by-step process and you're provider will make it to our webpage in no time.

  • Open the content/data/providers.yml file on GitHub.
  • Press the Pencil Icon in the upper Right Corner of the Code Preview.
  • Add your provider to the correct category, following the following structure:
- title: { linter-provider }
  url: { linter-url }
  • Save your commit, and submit your pull request.

linter-docker's People

Contributors

arcanemagus avatar greenkeeper[bot] avatar greenkeeperio-bot avatar johnwebbcole avatar johnzook avatar lucasdf avatar renovate-bot avatar steelbrain avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar

linter-docker's Issues

Possible false positive for comments within a run command.

I'm getting a Empty / bogus instruction is invalid

This is part of my dockerfile. This runs correctly in docker.

RUN apk update \
  # psycopg2 dependencies
  && apk add --virtual build-deps gcc python3-dev musl-dev \
  && apk add postgresql-dev \

I have multiple lines after this one that start with && and they do not have this error.

Get error on save in Dockerfile

Every time I save a (valid) Dockerfile with this enabled, I get the following error message:

screen shot 2016-11-29 at 7 30 59 am

This is on macOS Sierra 10.12.1 in Atom 1.12.6 with dockerlint 0.2.0 installed globally via npm (the error happens both when I point linter-docker at this executable and when I leave it on the default). I have version 1.11.21 of the linter plugin installed.

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.12.0 of eslint-plugin-import was just published.

Branch Build failing 🚨
Dependency eslint-plugin-import
Current Version 2.11.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push The Travis CI build failed Details
  • βœ… ci/circleci: checkout_code Your tests passed on CircleCI! Details
  • βœ… ci/circleci: beta Your tests passed on CircleCI! Details
  • βœ… ci/circleci: stable Your tests passed on CircleCI! Details

Commits

The new version differs by 33 commits.

  • 8f668c7 changelog/package bumps
  • cd9d249 exclude tests from coverage + bump TS parser (#1095)
  • f0d0c4f webpack resolver: cache instance(s) of resolve function (#1091)
  • 8c9c3b8 Merge pull request #1085 from benmosher/packageDir-array
  • 5111c79 revert has removal per @ljharb's note
  • 412ee2e [Refactor] use "has" instead of ".hasOwnProperty"
  • e2fdc5f Fix typo: 'runtime'
  • d8ca5e2 fix typo
  • 04d1c29 Merge branch 'master' into packageDir-array
  • 72bb2cb merge import/paths setting into existing packageDir option
  • 4e37dbf changelog links
  • 2e41a70 Merge pull request #1081 from benmosher/release
  • 2e0ed83 Merge branch 'master' into release
  • ec87b64 Ignore type imports for named rule. (#1057)
  • d5d8b35 memo-parser cautionary note

There are 33 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of dockerlint is breaking the build 🚨

Version 0.3.5 of dockerlint was just published.

Branch Build failing 🚨
Dependency dockerlint
Current Version 0.3.1
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

dockerlint is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • βœ… ci/circleci: checkout_code Your tests passed on CircleCI! Details
  • ❌ ci/circleci: beta CircleCI is running your tests Details
  • ❌ ci/circleci: stable Your tests failed on CircleCI Details

Commits

The new version differs by 18 commits.

  • 4fb994d bump to 0.3.5
  • 35531dc push back the line in case of a comment after ignoring
  • 87575cc use beginsWith instead of startsWith
  • 6b1fcd0 bump to 0.3.2
  • c22a477 allow empty arrays to be specified
  • 12b8dd3 Merge pull request #43 from mulmschneider/patch-1
  • d8c8873 ignore lines starting with # (comment) while parsing
  • ead4ee8 Update docker.com links in Readme
  • efa4662 Merge pull request #39 from amancevice/no-trailing-spaces
  • fb4bf3f Check for trailing spaces in Dockerfile
  • 210920b Merge pull request #38 from hobti01/master
  • 359300b Add ARG instruction support
  • 519849f Merge pull request #36 from aerostitch/move_args_to_cmd
  • a90f80f Move flags to CMD to allow changing file name
  • bbb7165 Merge pull request #34 from ColinHebert/patch-1

There are 18 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Action Required: Fix Renovate Configuration

There is an error with this repository's Renovate configuration that needs to be fixed. As a precaution, Renovate will stop PRs until it is resolved.

File: package.json
Error type: The renovate configuration file contains some invalid settings
Message: Invalid regExp for packageRules[0].packagePatterns: ^eslint``

Dependency Dashboard

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

Detected dependencies

circleci
.circleci/config.yml
npm
package.json
  • atom-linter 10.0.0
  • atom-package-deps 5.1.0
  • dockerlint 0.3.9
  • eslint 6.8.0
  • eslint-config-airbnb-base 14.0.0
  • eslint-plugin-import 2.20.1
  • jasmine-fix 1.3.1

  • Check this box to trigger a request for Renovate to run again on this repository

Alternative to dockerlint compatibility?

Hello, I have noticed that dockerlint doesn't catch many issues in dockefile, such as the fact that base image name doesn't"t have a version or the maintainer is still used instead of using label etc... Is it possible to use lintter-docker with an alternative dockerfile linter npm package that I have used to great effects in my ci pipeline to better catch errors.

Some messages are not displayed

The current regex message parser does not include all kind of messages returned by dockerlint.

Empty file unparsed error: ERROR: /path/to/Dockerfile does not contain any instructions

Example 2:

RUN apt-get update

Unparsed error: ERROR: First instruction must be 'FROM', is: RUN

Example 3:

FROM someimage
CMD ["ls"]
CMD ["ls"]

Unparsed error: ERROR: Multiple CMD instructions found, only line 3 will take effect

An in-range update of eslint-plugin-import is breaking the build 🚨

Version 2.9.0 of eslint-plugin-import was just published.

Branch Build failing 🚨
Dependency eslint-plugin-import
Current Version 2.8.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint-plugin-import is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • βœ… ci/circleci: checkout_code Your tests passed on CircleCI! Details
  • βœ… ci/circleci: stable Your tests passed on CircleCI! Details
  • ❌ ci/circleci: beta Your tests failed on CircleCI Details

Commits

The new version differs by 101 commits.

  • 180d71a bump plugin to v2.9.0
  • 0231c78 Merge pull request #1026 from isiahmeadows/patch-1
  • ae5a031 Missed a link
  • 5b0777d Add no-default-export + docs/tests (#936)
  • ff3d883 Merge pull request #1025 from patrick-steele-idem/update-dependencies
  • 654d284 Merge pull request #1024 from patrick-steele-idem/issue-1023
  • 9b20a78 Upgraded "find-root" and "lodash.get" for the webpack resolver
  • 8778d7c Fixes #1023 - Load exceptions in user resolvers are not reported
  • 91cfd6d Merge pull request #1022 from nevir/patch-1
  • 0e729c7 no-self-import is unreleased
  • 219a8d2 Merge pull request #1012 from silvenon/extensions-export
  • ab49972 Support export declarations in extensions rule
  • 3268a82 Merge pull request #1010 from silvenon/extensions
  • fdcd4d9 Add a .coffee test proving extension resolve order
  • bc50394 Merge pull request #1009 from silvenon/extensions

There are 101 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

Version 4.18.0 of eslint was just published.

Branch Build failing 🚨
Dependency eslint
Current Version 4.17.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • βœ… ci/circleci: checkout_code Your tests passed on CircleCI! Details
  • βœ… ci/circleci: stable Your tests passed on CircleCI! Details
  • ❌ ci/circleci: beta Your tests failed on CircleCI Details

Commits

The new version differs by 14 commits.

  • 883a2a2 4.18.0
  • 89d55ca Build: changelog update for 4.18.0
  • 70f22f3 Chore: Apply memoization to config creation within glob utils (#9944)
  • 0e4ae22 Update: fix indent bug with binary operators/ignoredNodes (fixes #9882) (#9951)
  • 47ac478 Update: add named imports and exports for object-curly-newline (#9876)
  • e8efdd0 Fix: support Rest/Spread Properties (fixes #9885) (#9943)
  • f012b8c Fix: support Async iteration (fixes #9891) (#9957)
  • 74fa253 Docs: Clarify no-mixed-operators options (fixes #9962) (#9964)
  • 426868f Docs: clean up key-spacing docs (fixes #9900) (#9963)
  • 4a6f22e Update: support eslint-disable-* block comments (fixes #8781) (#9745)
  • 777283b Docs: Propose fix typo for function (#9965)
  • bf3d494 Docs: Fix typo in max-len ignorePattern example. (#9956)
  • d64fbb4 Docs: fix typo in prefer-destructuring.md example (#9930)
  • f8d343f Chore: Fix default issue template (#9946)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of eslint is breaking the build 🚨

☝️ Greenkeeper’s updated Terms of Service will come into effect on April 6th, 2018.

Version 4.18.2 of eslint was just published.

Branch Build failing 🚨
Dependency eslint
Current Version 4.18.1
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

eslint is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • βœ… ci/circleci: checkout_code Your tests passed on CircleCI! Details
  • βœ… ci/circleci: stable Your tests passed on CircleCI! Details
  • ❌ ci/circleci: beta Your tests failed on CircleCI Details

Release Notes v4.18.2
  • 6b71fd0 Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" (#10022) (Mathieu Seiler)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030) (Teddy Katz)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028) (Teddy Katz)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019) (Jamie Davis)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020) (Teddy Katz)
  • 33177cd Chore: make library files non-executable (#10021) (Teddy Katz)
  • 558ccba Chore: refactor directive comment processing (#10007) (Teddy Katz)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010) (Teddy Katz)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006) (Teddy Katz)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985) (Rachael Sim)
Commits

The new version differs by 12 commits.

  • 22ff6f3 4.18.2
  • 817b84b Build: changelog update for 4.18.2
  • 6b71fd0 Fix: [email protected], because 4.0.3 needs "ajv": "^6.0.1" (#10022)
  • 3c697de Chore: fix incorrect comment about linter.verify return value (#10030)
  • 9df8653 Chore: refactor parser-loading out of linter.verify (#10028)
  • f6901d0 Fix: remove catastrophic backtracking vulnerability (fixes #10002) (#10019)
  • e4f52ce Chore: Simplify dataflow in linter.verify (#10020)
  • 33177cd Chore: make library files non-executable (#10021)
  • 558ccba Chore: refactor directive comment processing (#10007)
  • 18e15d9 Chore: avoid useless catch clauses that just rethrow errors (#10010)
  • a1c3759 Chore: refactor populating configs with defaults in linter (#10006)
  • aea07dc Fix: Make max-len ignoreStrings ignore JSXText (fixes #9954) (#9985)

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Linter does not follow ESCAPE directive

As specified in Dockerfile reference:

# escape=\
# escape=`
The escape directive sets the character used to escape characters in a Dockerfile. If not specified, the default escape character is \.
The escape character is used both to escape characters in a line, and to escape a newline. This allows a Dockerfile instruction to span multiple lines. Note that regardless of whether the escape parser directive is included in a Dockerfile, escaping is not performed in a RUN command, except at the end of a line.
Setting the escape character to ` is especially useful on Windows, where \ is the directory path separator. ` is consistent with Windows PowerShell.

linter-docker does not currently check the escape directive and will report a line error if another character is used.

Can't get it to work

Hi there,
unfortunately I cannot get the plugin to work. Here's what I've done so far:

npm install -g dockerlint
npm install -g atom-linter
apm install linter-docker

I am still unsure about the following:

  1. Which path do I have to enter for "Some executable path"?
  2. How does my Dockerfile has to be named in order to be picked up by the linter? So does "Dockerfile" work for example?

Thanks a lot,
Sebastian

Implement specs

It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.

Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.

If you need any help feel free to ask!

Incorrect lint errors about single quotes

I'm not sure if anyone is still maintaining this plugin, but:
For linter-docker 0.1.4 with linter 1.11.21

I get the error Arguments to ENTRYPOINT in exec must not contain single quotes at line 2 col 1 for the following Dockerfile

FROM alpine:latest
ENTRYPOINT [ "/bin/bash" ]

This Dockerfile doesn't contain single quotes in it anywhere.

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.