Symbols are the same color as strings (Ruby) about one-dark-syntax HOT 7 CLOSED

symbols are indeed the same color as strings. Symbols could be replaced with any of these.

Maybe @bright-orange?

It would only clash with .source.ruby.embedded. Not sure if that's a problem.

from one-dark-syntax.

@bright-orange would definitely be better, and seems to be one of the only colors that wouldn't clash too much, but aesthetically I'm not sure I like it. It's a bit too... I dunno, bright and saturated? Enough that it's a little distracting.

I looked at all the other available colors, and they all clashed too much except @cyan, but that one was a bit too subtle. Personally, I think it might be worth adding another shade of blue to the color scheme, something stronger than @blue and @cyan – that seems like it would work well for symbols.

EDIT: Probably not this exact hue of blue, but something @dark-blue basically:

(Also I think it would be good to make the : match the symbol color for Ruby at least)

from one-dark-syntax.

Actually @blue should be a bit stronger in general since it's very close to the normal text. Adding another darker blue, might be too much blue? Not in your context, but in others. This theme is based on "base16 tomorrow" but I think it's ok to tweak the colors a bit. Made a new branch sm-improve-colors: https://github.com/atom/one-dark-syntax/tree/sm-improve-colors

Your example would look like this:

Another ruby example like this:

from one-dark-syntax.

The colors will probably change some more. Maybe even try another scheme. Base16 Tomorrow just seemed the most fitting.

from one-dark-syntax.

@simurai Thanks for taking a look at this! I have one more symbols request (I could open a new issue for this if you want but it seems too minor for that) – could you change the : color from orange to @cyan to match the symbol color? In Ruby the : isn't an operator like in many other languages, it's a part of the syntax for writing symbols, so it's a little weird for it to be a different color.

from one-dark-syntax.

Ohh.. right, you mentioned that above. It's not just the : in front of a symbol, also the one after, right? Pushed a fix like this:

from one-dark-syntax.

Yup! Perfect. Thanks!

from one-dark-syntax.