atom / one-dark-syntax Goto Github PK

Carried over from atom/atom#6141

One Dark syntax theme colors all Java code yellow

Expected:

int main() {
    if (a or b and c || d && e) {
    }
}

See atom/language-c#157

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.2.4
System: Mac OS X 10.11.1
Thrown From: one-dark-syntax package, v1.1.1

Stack Trace

Failed to activate the gruvbox theme

At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

LessError: variable @mono-3 is undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

Commands

Config

{
  "core": {
    "themes": [
      "gruvbox",
      "one-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
Parinfer, v0.9.0
hyperclick, v0.0.35
minimap, v4.16.2
nuclide-file-watcher, v0.0.35
nuclide-fuzzy-filename-provider, v0.0.35
nuclide-open-filenames-provider, v0.0.35
nuclide-quick-open, v0.0.35
nuclide-recent-files-provider, v0.0.35
nuclide-recent-files-service, v0.0.35
proton-mode, v0.1.0
python-yapf, v0.9.1
relative-numbers, v0.2.4
vim-mode, v0.63.0

# Dev
No dev packages

Hi, what css do I need to write into my custom css atom file if I want to decrease the brightness of the grey editor background?

It think it is a really good looking theme but for me personally the background is too bright to look at it all day long. (In the risk of the grey color being part of a color composition together with the other colors. Maybe there is a bigger thought behind this?) Thanks.

but keep stuff like brackets, punctuation etc dark. Origin: #9

A few syntax color variables have been added: https://github.com/atom/atom/blob/91710894660018988cfa87c5132333129dd1f0c6/static/variables/syntax-variables.less#L32-L43

Initially they will be used for autocomplete. Overriding them in the theme will make autocomplete look more consistent with the rest of the theme.

ps. don't forget the light theme and possibly more.

from is being highlighted correctly like so:

but incorrectly when used elsewhere, afaik it's not a reserved word?

Unsure if this is a one-dark-syntax issue or a greater atom issue, so sorry if this is in the wrong place

hello. i work with large json files periodically, and noticed something that i miss in 'one dark syntax' theme.
sublime material theme has next json highlighting:

this is the same chunk, but in atom with one dark syntax:

keys of keys has more saturated red color, and 'root' keys are purple at all.
it is not critical, but significantly improves understanding of structure, especially when you are tired.

also - maybe there is a reason to make color of quotes a bit darker, so user could focus more on keys / values, not quotes (example)

Because the gutter is not visually separated from the editing pane, it is very hard to tell, where the first column is, and whether the cursor is currently at the start of the line, or not.

I get confused when the tag name is highlighted like this -- it's very similar to the cursor highlight, and in my peripheral vision, it looks like I have multiple cursors, and makes me hesitate before typing.

Can you come up with something else?

Poking around the files I see s syntax-text-color variable is light gray.

However, in an HTML file, my text is light blue, same as the tag punctuation:

I opened Atom today and noticed that my page had a LOT of red on it. I know this wasn't how it was before. For example, in the screenshot, this.props.isLoading should not be all red. I believe only the this was red before?

Any thoughts?

I want to test some change in the styles of my local Atom, but I can't find where one-dark-syntax package is. My goal is to add support for pug (jade) syntax.

Can you help me?

Hi,

I observed in the last commit that a link within a comment isn't well coloured.

Gaspar

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.0.11
System: Mac OS X 10.10.4
Thrown From: one-dark-syntax package, v1.1.0

Stack Trace

Failed to activate the 2-dark-syntax theme

At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

LessError: variable @mono-3 is undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

Commands

     -8:39.3.0 core:backspace (atom-text-editor#one-dark-ui.fontSize.editor.mini.is-focused)
     -8:38.9.0 core:confirm (atom-text-editor#one-dark-ui.fontSize.editor.mini.is-focused)
  6x -8:15.3.0 application:new-file (atom-pane.pane.active)
  4x -8:09.0 core:close (atom-text-editor.editor.is-focused)
     -6:41 core:confirm (atom-text-editor.editor.mini.is-focused)
     -6:32.2.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -5:05.9.0 core:move-right (atom-text-editor.editor.mini.is-focused)
  2x -5:05.4.0 core:move-left (atom-text-editor.editor.mini.is-focused)
  2x -3:52.8.0 color-picker:open (div.settings-view.pane-item)
     -3:18 core:undo (atom-text-editor.editor.is-focused)
     -3:03.4.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -2:48 core:confirm (atom-text-editor.editor.mini.is-focused)
  4x -2:15.7.0 core:close (atom-text-editor.editor.is-focused)
     -2:13.7.0 settings-view:open (atom-workspace.workspace.scrollbars-visible-when-scrolling.theme-one-dark-syntax.theme-one-dark-ui)

Config

{
  "core": {}
}

Installed Packages

# User
atom-smart-tabs, v0.1.0
browser-plus, v0.0.34
code-links, v0.3.11
color-picker, v2.0.11
less-autocompile, v1.0.0
less-than-slash, v0.8.0
navigate, v0.1.10
new-tab, v0.4.1
tabs-to-spaces, v0.11.1

# Dev
No dev packages

One Dark

Atom Dark

I would like to see this mistake:

be more visually dissimilar from the intended code:

like so:

But I'm afraid my implementation is too tightly coupled to language-babel.

Would a PR for such an effect be wanted? If so, is .meta.brace.curly.js an appropriate thing to target to reset the style back to normal for JS blocks escaped by { }?

Really like that this is the default theme now, but one thing different from Atom Dark that I find annoying is that keyword arguments in Python aren't highlighted. So if I have for example:

spam(ham, eggs='foo')

This would highlight eggs (but not ham). I'm quite used to this and I feel like I'm missing some instant grokability without it.

@supports not (-webkit-backdrop-filter: blur(10px)) {
  background: rgba(230, 230, 230, 1);
}

All CSS that comes after the first line loses its color coding.

Screenshot:

I'm not sure if this is the platform (ArchLinux) or the font (Source Code Pro) to blame, but this doesn't occur with the Atom Dark theme.

Steps to reproduce:

1. right-click on file in Tree View and then click Rename
2. click or use the arrow keys to re-position the cursor within the Rename modal dialog
3. notice that there is no indication of where the cursor is positioned

I noticed that using this theme (and a few others such as Firewatch and Gruvbox) that the comments shift text on code lines below such that it pushes them almost onto other lines like so:

Using the atom dark syntax theme rather than one dark syntax fixes this however.

Not sure what causes this or if it is intended. :)

Thank you, thank you, THANK YOU!!! 👍 👍 👍

Look on last 3 variables in line 2

The screenshots show beautiful, fizzy colours! They were perhaps a bit too bright for some, but I think over the last few months the One Dark combination has become a little gloomy.

So, since I know about nothing on this subject: is it possible to give the One Dark theme an option to inject a little bright, bold happiness into the syntax? Or do I need to fork this repo and make the changes?

tl;dr: Can a UI theme control/affect syntax themes in any way?

Apologies if this issue is inappropriate (because it really isn't an issue, more of a question).

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 0.210.0
System: Mac OS X 10.10.3
Thrown From: one-dark-syntax package, v0.7.1

Stack Trace

Failed to activate the retro-gruvbox theme

At variable @mono-3 is undefined in /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

LessError: variable @mono-3 is undefined
  at /Applications/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/language.less:2:9

Commands

     -0:34.7.0 settings-view:install-packages-and-themes (ul.list-inline.tab-bar.inset-panel)

Config

{
  "core": {
    "themes": [
      "atom-dark-ui",
      "one-dark-syntax"
    ]
  }
}

Installed Packages

# User
atom-jade, v0.3.0
autocomplete-php, v0.3.6
autocomplete-python, v0.4.3
autocomplete-ruby, v0.1.0
color-picker, v2.0.7
language-htaccess, v0.1.1
minimap, v4.10.0

# Dev
No dev packages

I sometimes use <a href="blah" target="_blank"> HTML tags in my Markdown code when "open the link in a new browser" behavior is appropriate.

Unfortunately the underscore character with in "_blank" triggers the syntax to try to show "Markdown italicized" formatting until a "closing" underscore is encountered somewhere else.

See attached image.

I've noticed that in Ruby, symbols are now the same color as strings, which makes it kind of hard to figure out just from the color scheme whether something is a symbol or string.

One Dark:

Atom Dark:

(Also applies to one-light-syntax)

Hi,
not a big issue but occasionally annoying as it make me feel my code is wrong :)

It happens on any syntax theme and not only with constructor keyword.
Thank you.

Looks kind of washed out and hard to read when typing a long message.

This will have the .message and .git-commit classes on it.

Something like in Atom dark https://github.com/atom/atom-dark-syntax/blob/master/index.less#L158-L161

The current-result is hard to tell apart from the other find-results. The line number is highlighted, but the "markers" could be stronger too.

The comment in one-dark-syntax is a little hard to read, even though I love the rest part, this drawback is painful.

It would be nice if this theme highlighted valid CSS property names like in e.g. Atom Dark.

As the title says, the word "DISTINCT" in SQL doesn't seem to be highlighted - and it's a quite important keyword in my opinion.

Currently there are a few "specs" under atom/one-dark-syntax/spec.

But it would be better to have them in a separate repo. Then all theme authors could use them and it's not tied to this One. Also, easier to update them in just a single place. And we could reference them from the docs.

I made a new repo here: https://github.com/simurai/language-examples. It contains examples for all the core languages.

@atom/feedback if this is a good idea, could somebody create a new repo for it, maybe atom/language-examples?

I've installed the package and I'm using the default Atom font family which looks a little different. Can you tell me which family is the one used in the screenshots.

Thanks a lot

(1) The background should be much closer to black

(2) The text should be high in brightness (e.g. default text should be white/#fff)

This is a large usability concern. Without high contrast, text is much more difficult to read.

Comparison to Sublime:

Atom:

Sublime:

I have other editor colors than in the repo screenshots, both light and dark theme, what's wrong with colors?

atom-0.175.0-696c795 (Linux)

Are these the new colors of this syntax theme ?

If yes, the repo would need an updated screenshot.
If not, I have something wrong with my setup.

"const" keyword is not colorised in destructuring assignment in ES6 .js file

Problem: One Dark is originally based on base16-tomorrow which uses red for highlighting (e.g. variables). In base16-tomorrow it's somewhat muted, but in One dark the red is stronger and could make it look like it's some kind of "error".

Ref: atom/language-javascript#263, atom/language-javascript#258

Solution: Replace red with something else.

Currently operators like +,!==, ||, typeof and new aren't highlighted in JavaScript.

Is this intended behaviour?

Syntax highlighting for TypeScript works really well, but it does not work in the case where I'm writing JavaScript with Flow type annotations.

Flow:

TypeScript:

The One Syntax theme breaks when using https://atom.io/themes/isotope-ui.

I think the problem is that Isotope tries to use the @syntax-background-color from One, but that one uses a variable imported from another LESS file (color.less), which Isotope does't (and shouldn't) import. https://github.com/atom/one-dark-syntax/blob/master/stylesheets/syntax-variables.less#L17

I'll have to look into it more, but maybe as a rule, the "official" syntax variables aren't allowed to be dependant on importing other files.

/cc @braver (no need to change anything in Isotope, just FYI)

Standard code blocks are highlighted in green.

```
$foo = new Foobar;
```

But code blocks with their language specified don't have any highlighting at all.

```php
$foo = new Foobar;
```

Most of the content is greyed out :(

Why is the status-added class shown in the status bar blue? I would assume it would be the same as text-color-added which maps to text-color-success which is green in my case.

Is this intentional because blue is easier on the eyes?

My understanding is that in a code block characters that would otherwise require escaping with backslash (i.e. *, _ etc) do not require escaping.

I am finding that whilst the generated result is correct the source syntax highlighting is ruined. This is particularly painful as I am writing SQL code blocks which contains lots of underscores and stars.

Below is an excerpt from one of my files

[Enter steps to reproduce below:]

1. ...
2. ...

Atom Version: 1.0.19
System: Mac OS X 10.10.5
Thrown From: one-dark-syntax package, v1.1.0

Stack Trace

Failed to activate the one-dark-vivid-syntax theme

At variable @syntax-bracket-matcher-background-color is undefined in /Users/zhanglizeyi/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/editor.less:26:22

LessError: variable @syntax-bracket-matcher-background-color is undefined
  at /Users/zhanglizeyi/Downloads/Atom.app/Contents/Resources/app.asar/node_modules/one-dark-syntax/styles/editor.less:26:22

Commands

     -3:57.8.0 settings-view:install-packages-and-themes (atom-text-editor.editor.is-focused)
     -3:32.1.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -3:29.9.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:44.2.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -2:42.1.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -2:37.5.0 core:backspace (atom-text-editor.editor.mini.is-focused)
     -2:36.7.0 core:confirm (atom-text-editor.editor.mini.is-focused)
     -0:33.5.0 symbols-view:toggle-file-symbols (div.settings-view.pane-item)
     -0:20.3.0 core:paste (atom-text-editor.editor.mini.is-focused)
     -0:19.8.0 core:confirm (atom-text-editor.editor.mini.is-focused)

Config

{
  "core": {}
}

Installed Packages

# User
atom-rainbow-syntax, v0.1.1

# Dev
No dev packages