Git Product home page Git Product logo

Comments (8)

martinbean avatar martinbean commented on June 7, 2024

Seems the trait syntax messes up further syntax highlighting too:

screen shot 2017-09-12 at 22 20 03

from one-dark-syntax.

50Wliu avatar 50Wliu commented on June 7, 2024

I believe both issues have already been fixed, and I will be looking into creating a patch release.

from one-dark-syntax.

martinbean avatar martinbean commented on June 7, 2024

@50Wliu Awesome! Thanks for addressing this Issue so quickly.

Is there an ETA on the patch version?

from one-dark-syntax.

martinbean avatar martinbean commented on June 7, 2024

These styling issues have made their way in the stable version of Atom for me now 😢

from one-dark-syntax.

50Wliu avatar 50Wliu commented on June 7, 2024

I can't commit to a timeframe, but I can confirm that a hotfix will be released for these issues.

from one-dark-syntax.

mkarnicki avatar mkarnicki commented on June 7, 2024

Looking forward to it, @50Wliu . I can confirm 1.20.0 is also affected.
screen shot 2017-09-14 at 20 14 49

from one-dark-syntax.

stefblokdijk avatar stefblokdijk commented on June 7, 2024

Hey, i'm still having this issue.
Didn't found any update yet that fixed this.

I made a little css fix to go back what I was used to.
Just add the css code to the atom styling.

CSS Fix

/**
 * Fix for PHP Language
 */
.syntax--use .syntax--class.syntax--php,
.syntax--method-call .syntax--entity.syntax--name.syntax--function,
.syntax--punctuation.syntax--definition.syntax--class.syntax--bracket.syntax--curly.syntax--php,
.syntax--punctuation.syntax--definition.syntax--class.syntax--bracket.syntax--curly.syntax--php,
.syntax--namespace + .syntax--class.syntax--php {
    color: #abb2bb;
}

.syntax--comment .syntax--class.syntax--php {
    color: #5c635f;
}

Before

before

After

after

from one-dark-syntax.

martinbean avatar martinbean commented on June 7, 2024

Is it possible to get an ETA for the “official” fix? As this has been “broken” for some weeks now.

from one-dark-syntax.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.