Comments (5)
Cool! I really like this idea. A few pieces of feedback:
- It might be wise to have a permissive format for commit messages – some teams use the
"[Push Notifications] Fixes whatever..."
format, for example. We could use that format for Jira tickets. - GitHub uses visual design to show when something like "fixes #123" in a PR body will close an issue. We might want Peril to comment on the PR with a message like "Merging this PR will move PLATFORM-89 to Review column", with PLATFORM-89 turned into a link to that ticket.
- Different teams use different columns in Jira, so our implementation might have to handle moving to different columns based on which project the ticket is in.
from peril-settings.
It might be wise to have a permissive format for commit message
It's totally permissive, there's no attempt at forcing a format - I think [PLAT-123] did a thing
would not pass the regex though. Could add an extra regex for that too.
GitHub uses visual design to show when something like "fixes #123" ...
We could have a "Synced with Jira" label, that means less Peril noise and easy to know that it's happening.
Different teams use different columns in Jira
Great, will convert the check into an includes in an array instead of string matching 👍
from peril-settings.
It's totally permissive, there's no attempt at forcing a format - I think [PLAT-123] did a thing would not pass the regex though. Could add an extra regex for that too.
Added a test for this, it was supported already 👍
from peril-settings.
Does the current iteration of our automated Jira sync handle tickets with multiple associated PRs? For example, I have a Jira ticket for upgrading the version of rack used across a number of projects. I've been linking back to the same Jira ticket from each PR.
Should I be using multiple Jira tickets for this case?
from peril-settings.
Sub-tasks maybe? Or we can figure a way to make the message not indicate that it should close the ticket. It's very malleable, and the aim is to map to existing behavior, not necessarily define it if possible.
from peril-settings.
Related Issues (20)
- Disable assignee check for renovate PRs HOT 1
- Send reminders to platform leads before open egineering HOT 1
- Assignee shouldn't be required for Deploy PRs HOT 1
- [deploySummary] Use Github GraphQL endpoint instead of REST API
- [deploySummary] Enhancements to output
- [deploySummary] Move out of Peril, into Horizon HOT 2
- [Idea] Slack remindering about writing blog posts HOT 3
- Support #rebaseongreen trigger
- RFC: Validate PR description Changelogs on Eigen HOT 6
- RFC: Close stale PRs HOT 4
- adopt inclusive language HOT 1
- Peril running same check multiple times / spellchecking deleted code HOT 2
- RFC: Testing the scheduler - ignore me
- Add support for more merge on green statements HOT 1
- [RFC] Remind people about uncommented and unmerged PRs assigned to them
- Bug: Allow a GitHub review comment to also trigger setting the merge on green label HOT 1
- Add a rule for checking if you add a new key to the global rules that you should update the peril doc in readme
- Merge on green bug
- Ensure auto label doesn't exist before creating it
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from peril-settings.