RFC: Close stale PRs about peril-settings HOT 4 CLOSED

+1

I think the poll would be great, but maybe we can raise awareness related to the fact that branching itself it's a bit of an antipattern in terms of Continous Integration/Delivery but a necessary pain, having abandoned/Long-lived PRs it's even worse because several issues as:

• (i) delayed integration,
• (ii) contextual and semantic conflicts, and
• (iii) risky deployments since we do not know what we do not know about the side-effects/feedbacks against the current codebase.

The main point that I want to make here it's that we, Artsy Engineers, should be a bit more mindful in terms of PR backlog hygiene.

By the way, thanks for the RFC.

from peril-settings.

+1 as well!

Closing a PR is not dangerous or permanent in any way, but is a clear indication that something has been handled (merged, deprioritized, abandoned, etc).

There is no reason to keep visual and mental clutter around in projects when we can simply re-open anything that is closed by accident or incorrectly.

from peril-settings.

Great, thanks to everyone for your feedback. I will solve this RFC then and bring it to life

from peril-settings.

Resolution

We decided to do it

Level of Support

2: Positive feedback.

Next Steps

We will implement it.
I will make a poll in the #dev channel to discuss with folks the duration after which we can consider a PR stale.

Exceptions

We will be only implementing this in Eigen, Force, Metaphysics, and Volt then probably enable this for other repos.

from peril-settings.