Proposal: Whenever a PR is created in Eigen and is ready, check th

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

Could one use Eigen's local <a href="https://github.com/artsy/eigen/blob/master/Danger

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

RFC: Validate PR description Changelogs on Eigen about peril-settings HOT 6 CLOSED

MounirDhahri commented on June 23, 2024 1

RFC: Validate PR description Changelogs on Eigen

from peril-settings.

Comments (6)

MounirDhahri commented on June 23, 2024 3

@kajatiger yes, we can do that, this is how I am doing it

peril-settings/org/allPRs.ts

Lines 231 to 236 in 66d05d5

 const repoName = pr.base.repo.name 

 if (repoName !== "eigen") { 

 console.log("Skipping this check because the active repo is not Eigen") 

 return 

 }

from peril-settings.

damassi commented on June 23, 2024 1

Could one use Eigen's local Danger file rather than making changes to peril?

from peril-settings.

MounirDhahri commented on June 23, 2024 1

@damassi makes complete sense, I didn't know danger supports local configurations. I will check it now

from peril-settings.

kajatiger commented on June 23, 2024

I like this idea! Can we implement eigen-only rules in peril?

from peril-settings.

dblandin commented on June 23, 2024

makes complete sense, I didn't know danger supports local configurations. I will check it now

Here are some examples of rules that are defined in specific repos but executed by Peril:

https://github.com/artsy/peril-settings/blob/master/peril.settings.json#L22-L41

from peril-settings.

MounirDhahri commented on June 23, 2024

I will this for now since I moved the logic to be inside Eigen 🙌 Thanks everyone for the feedback.
If anyone is interested in the implementation details. Here is it: artsy/eigen#4815

from peril-settings.

Recommend Projects