arpankg / ctci-python-solutions Goto Github PK

Line 43 should use the items() method over the dictionary to return (key, value) pairs.

for (key, value) in counts.items():

Or, use the values() method over the dictionary since we are only checking values.

for value in counts.values():

Hey @arpan74,
I was going through CTCI chapter 16 - Moderate so thought I might as well contribute as I am doing them anyway.

Question:
Are the links dynamically generated or are they hardcoded? I am referring to the header and readme status links to "Read solution".
In other words, if I was to push a file explaining question 16.1, how would you want me to format the header? Leave the link as blank so you can update them later or are these mdx file fed into a system somewhere that generates dynamic webpages as the mdx files are pushed to this repo?

Great work with the solutions! I've been trying to access the solution links but I keep getting 404 error.

The output matrix should be:
[
[1, 0, 3, 0],
[0, 0, 0, 0],
[6, 0, 1, 0],
[0, 0, 0, 0]
]
instead of
[
[1,0,3,4],
[5,0,7,8],
[6,0,1,2],
[0,0,0,0]
]

row 2 (matrix[1]) becomes 0 because matrix[1][1] (item next to 5 in second row) is 0 and the last column becomes 0 because the last item in the column is 0.

Hello! This is my first time using GitHub, so I apologize if this is comment is old news. I wanted to see if this particular solution for question 1.4 might be considered as another option. Thank you for creating this repo! I've been enjoying it.

You are given a string. Write a function that checks if the letters in the string can be rearranged to form a palindrome (or if the input is already a palindrome). You can ignore spaces in the string.

def palindrome(s):
  # Remove spaces
  s = s.replace(" ","")
  # Check if s is == the reversed s
  return s == s[::-1]`

Line 15 is missing check to length of dictionary. Following should work:

return len(count) == 0