arindam1993 / pybiosim Goto Github PK

Angles are sometimes expressed as Radians, but the Simulator initial conditions and a few other locations are in Degrees. Choosing one convention (I recommend radians) for the whole simulator and sticking to it is less confusing.

When all of the agents are stunned line 36 of NavUtils generates an error min() arg is an empty sequence.

In left-handed coordinates (much like right-handed coordinates) the positive rotation around an axis is defined such that when you align your thumb with the positive axis direction, your fingers curl around the axis in the positive rotation direction:

(image from the POVray documentation)

Careful inspection and setting up several tests has yielded an error:

This test robot commanded positive pitch for 4 seconds. Clearly, it does not follow the definition illustrated above.

Simple tests for translation in X, Y and Z, as well as rotation for Yaw and Roll behave appropriately for a left-handed coordinate system.

The main directory contains 4 .pyc files, despite the .gitignore file containing a rule to ignore those platform specific cache files.

I also noticed that the folders images and reference_demos are listed in the .gitignore file, but it looks like you actually don't want to exclude the folders themselves (which is the current configuration). My best guess here is you want to keep the images folder and ignore the contents of the folder [and delete the jpgs currently in the repository under that folder], and not ignore the files in 'reference_demos`.

Personally, I suggest looking at github's Python .gitignore file and using it directly with a specific addition for the folders at the top.

I can package this up into a pull request if you would like, provided you give some feedback on how the folders are supposed to behave.

Thanks,

@SterlingPeet