aprilsylph / xkit-rewritten Goto Github PK

To block another post in the same session, peepr must be opened after blocking each post. Needs further testing.

Hiya :)
Just started using your xkit yesterday, hoping to see an ad removing feature if possible? I use an adblocker and other script editors to remove ads, so there are no ads on my dash, but there
is still a white square that has the "sponsored" symbol between posts occasionally.
Would love to see this feature again.

Thanks! (I've attached a screenshot below)

For users with a long list of Quick Tags, the Quick Reblog popup extends down the dashboard to the point of scrolling. Having the option to put Quick Tags in a scroll box like (old) New XKit 7 would be beneficial.

Whenever Quick Reblog is restarted (for example, because a preference was changed), a new redundant set of blog options will appear in the blog selector.

I didn't see any mention of these within Excluded or Removed features in the wiki, nor elsewhere in this repo. If it's feasible from a coding perspective, please consider re-adding the following features that we found very helpful!

• Outbox
• Scroll-to-Bottom
• Glowing Follow (Could be a sub-option of Mutual Checker)
• (for Quick Reblog), One-Click Postage's ability to add tags AND caption directly from the popup

• The browser I'm using is: Firefox
• My browser version is: 89.0.2 (64-bit)
• My XKit Rewritten version is: 0.4.3

Drafted posts seem to have a different structure from other posts, and the article parent div does not have a specified position, breaking "Expand" buttons considerably and removing avatars from shortened posts.

I would like to request an option to track blogs, like New XKit had. I was surprised to not find it here, especially because the tracker had started malfunctioning heavily in New Xkit, to the point where I had to go to the Members section of a sideblog to even see the tracker. Perhaps that's the reason why it couldn't make a comeback, but if it were possible and not an absolute nightmare to make, I would definitely love to see it make a comeback. It was one of my favourite functions, if not my absolute favourite.

Thank you very much for your time and efforts!

I found it a bit surprising/confusing when my own posts (that are reblogs) were hidden from the dash by Show Originals.

I could sort of imagine someone wanting the current behavior, but it seems much more niche to me than either seeing all of the user's posts (this suggestion) or none of them (which would be done via Tweaks, of course).

• The browser I'm using is: Firefox
• My browser version is: 89.0.1 (64-bit)
• My XKit Rewritten version is: 0.3.4

1. Somehow, notifications are being found on the page when there aren't any
2. React property checking is not perfectly robust

Uncaught (in promise) TypeError: fiber.memoizedProps is null
    <anonymous> https://www.tumblr.com/dashboard:10
    <anonymous> https://www.tumblr.com/dashboard:6
    async* https://www.tumblr.com/dashboard:19
dashboard:10:12
    <anonymous> https://www.tumblr.com/dashboard:17
    forEach self-hosted:208
    <anonymous> https://www.tumblr.com/dashboard:6
    InterpretGeneratorResume self-hosted:1485
    AsyncFunctionNext self-hosted:695
    (Async: async)
    <anonymous> https://www.tumblr.com/dashboard:19
    inject moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/inject.js:49
    inject moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/inject.js:8
    processNotifications moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/scripts/notificationblock.js:13
    runOnBaseContainerMutated moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:35
    forEach self-hosted:208
    runOnBaseContainerMutated moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:35
    timeoutID moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:29
    (Async: setTimeout handler)
    debounce moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:29
    observer moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:59
    (Async: MutationCallback)
    <anonymous> moz-extension://39f28386-b514-4b3d-af80-440625b13ff5/util/mutations.js:37
    InnerModuleEvaluation self-hosted:2384
    InnerModuleEvaluation self-hosted:2384
    evaluation self-hosted:2335

This was a vital feature of the previous New XKit. Inline ads must be defeated once more.

why have they done this

I don't think Show Originals should be active in your own posts/drafts/queue, etc. That seems to go against its primary intended use in my mind. I can't think of any non-dashboard locations where it would make sense to hide reblogs, offhand, but I may have forgotten about one.

Quick Reblog does not currently remember the last selected blog. In the case where almost all reblogs are not made to the primary blog, selecting the correct blog every time becomes tedious.

#quick-reblog select ruleset should have font-family: var(--font-family); rule

Tumblr's built-in blacklist works great, but how the filtered post looks feels a little intrusive. It would be great to have an option to trim it:


and/or have an option to hide the post completely.

• The browser I'm using is: Brave
• My browser version is: Version 1.19.92 Chromium: 88.0.4324.152 (Official Build) (64-bit)
• My XKit Rewritten version is: v0.0.14 (Alpha)

When quick reblogging any post that has an Ask (at least that I have tested), the confirmation text is not Posted to <blogname>, but is Answered by <blogname>.

Why does Quick Reblog have this text when the user is not the person who answered the Ask? Even if the user is OP and did answer the Ask, they weren't necessarily answering it again when reblogging.

If this is the intended behaviour, please close this issue.

Title is pretty self-explanatory! Quite minor, but the textareas in preferences for e.g. hide avatars and the local storage import textarea have some unnecessary red squiggles.

Would it be possible to import data from New Xkit for features that have been migrated? For example, PostBlock and NotificationBlock both have datasets of posts I've blocked in New Xkit; it would be nice to migrate those lists into XKit-Rewritten rather than start from scratch.

Similar to previous XKit, where the Quick Post popout would appear above the reblog sign. Also useful for when infinite scroll is disabled (quick reblog popout can block the next page button).

• The browser I'm using is: Firefox for Windows
• My browser version is: 91.0.1
• My XKit Rewritten version is: 0.6.0

When quick-reblogging or queueing a post, the first attempt will sometimes display a 'failed to authorize' message. If attempted again, the quick post options will stick as 'processing' for all posts until the page is hard refreshed. Posts can still be reblogged normally if stuck this way.
The amount of posts before this occurs varies. Yesterday I would be lucky if one or two would quick post before it stuck, but today I queued about a dozen before seeing the issue again.

I think it'd be nice to have an option to make alt text visible to users not using screenreaders by inserting it as captions below the images, sort of like the "visible captions" option that used to exist back when tumblr image captions were a thing: https://github.com/new-xkit/XKit/blob/master/Extensions/accesskit.js#L407

I've been poking around at a rough draft of this, but I wanted to check first whether it sounds like a feature you'd be interested in adding atm (and also whether you're currently open for random new feature contributions at all, or if it'd be better to wait until the rewrite is further along/out of beta?)

• The browser I'm using is: Firefox
• My browser version is: 89.0 (64-bit)
• My XKit Rewritten version is: 0.3.1

Minimum width probably completely unnecessary or should be reduced; available width in new overflow menu is ~331px.

• The browser I'm using is: Firefox MacOS
• My browser version is: 89.0.1 (proton disabled); 90.0b12 (proton enabled)
• My XKit Rewritten version is: 0.4.4

When you have the XKit Rewritten icon pinned to the overflow menu in Firefox, it appears to gain a header when clicked on that shifts the content downward in a way that messes up the scroll bar. This happens in both my Firefox installs. Edge and Chrome appear fine.

The overflow menu in Firefox appears to do fairly bad things to basically all of my webextension popups, so I'm not exactly surprised, but.

(This screenshot is scrolled all the way down. The last menu item is completely hidden, so this is unfortunately a functional as well as cosmetic issue, albeit an easy-to-workaround one.)

Would it be possible to transfer/import the extension Panorama? I have a large widescreen monitor, and it helped scale the size of posts on the dash to an easily readable size.

Is it possible to add a shortcut for Quick Reblog, like how New XKit's "T" shorcut opened the reblog dialog? And could the blog that we last posted to be stored?

Currently the default volume is muted - it would be nice if this could be user-set instead.

• The browser I'm using is: Firefox
• My browser version is: 86.0.1
• My XKit Rewritten version is: 0.2.3

Like #95 but this time it only affects queued and drafted posts it seems. Now all posts including the first one of the page are not highlighted.

eb0ad27 inadvertently removed the check for if the queried blog is the user's own blog. this should be easily fixed by setting

following[myBlog] = Promise.resolve(false);

in the script's main() function.

i really like being able to edit reblogs with the new xkit extension - i'm part of the rp community, and i like to be able to trim my posts without losing my partner's reply :)

Hi there! Sorry to be That Windows User 😅 but I get an "invalid path" error during checkout when cloning the repository - seems like it's objecting to the colons in the some of the docs filenames:

$ git clone [email protected]:turtleseason/XKit-Rewritten.git
[...]
Resolving deltas: 100% (3162/3162), done.
error: invalid path 'docs/Chapter 1: Introduction.md'
fatal: unable to checkout working tree
warning: Clone succeeded, but checkout failed.
You can inspect what was checked out with 'git status'
and retry with 'git restore --source=HEAD :/'

Would it be possible to rename the files? I was able to work around it by excluding the docs directory locally with sparse-checkout, but it'd be great to avoid the issue altogether if possible.

• The browser I'm using is: Firefox
• My browser version is: 90.0.2
• My XKit Rewritten version is: 0.5.0

Really minor issue - I only even noticed because I track a tag with no posts in it (url of a blog) and was curious why its count was showing as 2+. I think filtering elements on objectType === 'post' here (or skipping items with no timestamp) would fix it? I could make a PR if that'd be helpful.

(Also, this feels almost too insignificant to mention, but while looking into this I noticed that tags with no posts always have a count of 0+ instead of just 0 - I have no idea whether people who aren't me bother tracking empty tags lol so I don't know if this warrants changing, but thought I'd mention it just in case)

• The browser I'm using is: Firefox
• My browser version is: 86.0
• My XKit Rewritten version is: v0.1.1 (Beta)

I noticed that the PostBlock I was using was the base Xkit version, rather than Xkit Rewritten. I uninstalled the addon from regular XKit, and now the Xkit Rewritten version doesnt show up- posts dont have a block button at all.

• The browser I'm using is: Firefox
• My browser version is: 86.0.1
• My XKit Rewritten version is: 0.2.1

Quick Reblog does highlight the reblog button right after reblogging, but when you refresh or navigate away from the page, it goes back to the default color. Curiously, the first reblogged post of the page is properly highlighted. I've tested across different Tumblr palettes, as well with Palettes for Tumblr disabled.

• My browser version is: Edge 92 (MacOS), Firefox 90 (MacOS)
• My XKit Rewritten version is: 0.6.1

exposeTimelines is missing descendentSelector-style code to handle >1 "timeline" CSS class existing.

This breaks the extensions that use it (seen posts, show originals, and the hide my posts tweak). Okay, I didn't actually test all 3, but it probably does.

It's great to be able to add tags from my tag bundles without opening the post editor, but that doesn't really match my process when I'm queuing up a lot of posts. I'd love to be able to add tags from the editor too.

Thanks for working on this! It's so nice to be running an XKit version where the features still work!

generated CSS from this option needs to be updated to expect RGB values from palette variables

Tumblr decided to force tag pages to the Top view instead of Recent (see https://changes.tumblr.com/post/661325788557246465). Choosing Recent doesn't stick across pageloads, and there's no user-set preference, so if you want Recent you have to click it on every tag, every time, which is a big pain when looking for new posts in tracked tags. Would it be possible to add a switch to TT+, or wherever would be appropriate, to provide a choice to always load the Recent sort?

post state is missing from fetch/put process

• The browser I'm using is: Chrome with duck duck go privacy essentials extension (2021.9.2)
• My browser version is: 93.0.4577.63
• My XKit Rewritten version is: 0.7.0

--- I added all the tag bundles I wanted, made sure quick tags was turned on, but there's no button for me to click in the tags area. Tried in regular and incognito modes, tried tumblr's "shiny new post editor" or not, turned off the duck duck go extension, even remembered to delete the old xkit, no button!

The wiki's installation section describes instructions for installing a webextension in developer mode and links to https://github.com/AprilSylph/XKit-Rewritten/blob/master/CONTRIBUTING.md, but this content has been moved to https://github.com/AprilSylph/XKit-Rewritten/blob/master/docs/Chapter%202%20-%20Getting%20started.md.

(Can't believe you can't PR a Github wiki! Seems like an odd omission.)

Similar to the user selection implemented in Hide Avatars, it would be great to have the ability to select users whose reblogs one does always want to see.

Would it be possible to add a field to the in-dash quick tags popup to type new tags, similar to how it worked in Xkit 7? It would be really helping for when you forget to tag a trigger warning or somesuch, for example.

The New XKit had a little Tag Tracking viewer that went in the sidebar and was super helpful; it actually took me a minute to realize the Tag Tracking in Rewritten was functional, because I was so used to the sidebar. It's minor, but I'd greatly appreciate it if this could be added!

Quick Reblog and Quick Tags currently use the XKit Rewritten addon icon for notifications:create for quick-n-dirty Chromium compatibility. Creating 128px square PNGs of their script icons to use instead would be much more preferable; when this is done, the notification titles could be changed to the script title too (Chromium notifications include the addon name anyway).

• The browser I'm using is: Firefox
• My browser version is: 88.0; MacOS 10.14.6
• My XKit Rewritten version is: Beta 0.2.9

Reblogging a post with quick tags and entering e.g. this tag has "a quote" in it results in the tags this tag has in it and a quote rather than this tag has "a quote" in it.

I see the comma separated tags are just sent directly to /posts, so presumably this is just a Tumblr API thing.

• The browser I'm using is: firefox
• My browser version is: latest
• My XKit Rewritten version is: latest

hi ! i was wondering why the extension originals only only works on the main dashboard and not on my own blog? (in dash view) it used to before but i can still see my own posts and reblogs despite ticking the preferences ; v ; thanks so much btw!

• The browser I'm using is: Firefox MacOS
• My browser version is: 89.0
• My XKit Rewritten version is: 0.3.1

The "check out these blogs" carousel can be placed immediately following an ad container, in which case its second part won't be hit by

and it therefore won't get hidden.

• The browser I'm using is: Firefox (MacOS)
• My browser version is: 85.0.1
• My XKit Rewritten version is: 0.2.3

When AccessKit/Pause GIFs is enabled, GIFs initially appear as Tumblr's not-yet-loaded gradient and stay that way until hovered. (I assume this is related to the lazy loading mentioned in Changes on February 5th.)

• The browser I'm using is: Firefox MacOS
• My browser version is: 89.0.1
• My XKit Rewritten version is: 0.4.1 and 0.3.0

Hide Avatars and Show Originals do not take any action when their textareas are updated. The textareas quietly revert back to their previous contents when the popup is closed.

This occurs in v0.3.0, but does not in v0.2.10. (I wish I knew how to use git bisect :P)

I assume it's either a product of the modules transition or a bug or oversight in the autoRestart -> onStorageChanged transition? Still looking.

• The browser I'm using is: Firefox
• My browser version is: 86.0
• My XKit Rewritten version is: v0.1.1

The QuickReblog popout sometimes stops appearing on hover altogether after certain actions on the dashboard until I refresh the page. This happens specifically if the popout is still open when: a video plays (prompted by user with Vanilla Video), or another QuickReblog popout appears. This is what I've observed so far, there might be more, but hopefully it's enough to state a pattern?