#define EMPTY causes break in subsequent includes about approvaltests.cpp HOT 6 CLOSED

(that you have an approval test running, I mean...)

from approvaltests.cpp.

B_Prevent_#define_EMPTY_breaking_in_subsequent_includes_-fixes#7.txt

from approvaltests.cpp.

B_Remove_#define_EMPTY_which_broke_code_in_later_includes_-fixes#7.txt

from approvaltests.cpp.

Thanks for reporting this!

I've been able to reproduce it by adding code based on your enum example above - and have then tried two ways of fixing it.

The first patch above adds the #undef, as suggested.

The second patch above uses a different approach - a helper function that returns the "empty" container. This is cleaner as there's no chance that we stomp on an earlier #define of EMPTY... I'm not super happy with the names though - as empty() returns a container with one value in!

@isidore and I are pairing on this library later this week, so we'll chat about this then and finalise a fix - as well as hopefully doing a new release, to make the fix available...

Note to self: I'd like to try and remove #define STATIC in Macros.h as well - or rename it to make a clash much less likely.

from approvaltests.cpp.

Thanks for the quick action! I saw your cpponsea talk on youtube and liked what I saw so gave it a try. Have my first approval test running now :)

from approvaltests.cpp.

I can't tell you how happy that makes me!!!

from approvaltests.cpp.