Comments (3)
Hi Pete, your screenshot is very clear in showing the problem.
I just checked and our GitHub Actions builds are still running and passing on a wide range of environments. The fact that they are passing tells me that the approved files in the repo (and not the build dir) are being found OK.
I think if this was a common problem, we would have had a lot more reports about it.
However, in case it's caused by a newer version of some tool or other, I would like to try and get to the bottom of it.
So the thing we need to work out is how your build differs from those that successfully place the approved and received files alongside the source code.
Is your project on GitHub, for me to test it out?
If not, please give me as much info as possible about the setup, including:
- all the CMake files
- the presets
- the command-line args used to run CMake
- The compiler with version
Thanks in advance.
from approvaltests.cpp.
I see you also submitted #195 - sorry not to have looked at that.
Is this the same problem, or something different?
from approvaltests.cpp.
There is now a project on GitHub to reproduce the issue (at least on my computer): https://github.com/Bktero/useApprovalsSubdirectoryBug
Writing this project, I found out that the issue depends on the generator. With MinGW Makefiles, it works; with Unix Makefiles, it doesn't. I have added the presets in the project.
I thought it was a different issue from #195 but now I think #195 is not completely relevant. Indeed, with the project I have just shared, you can reproduce #195 (and something very similar). To do so, remove the call to useApprovalsSubdirectory()
in test.cpp
. With the "failing" preset and you will get:
C:\......\useApprovalsSubdirectoryBug\test.cpp:4: Failure:
due to unexpected exception with message:
Failed Approval:
Approval File Not Found
File: "C:\......\useApprovalsSubdirectoryBug\test.MyTestCase.approved.txt"
The "successful" preset correctly creates the file. I hence tend to believe both #195 and #196 are linked (maybe the same).
Details about my setup:
- Catch 2.13.7
- ApprovalTests 10.12.2
- CMake 3.21.1
- gcc 11.2.0 (Rev10, Built by MSYS2 project)
- Windows 10 Entreprise (version 21H2, build 19044.1645)
Note that the project generates warnings:
C:/..../ApprovalTests.v.10.12.2.hpp:393:13: warning: 'errno_t getenv_s(size_t*, char*, size_t, const char*)' redeclared without dllimport attribute: previous dllimport ignored [-Wattributes]
Is this is an issue in ApprovalTests?
from approvaltests.cpp.
Related Issues (20)
- Add a copyright statement to the released single header HOT 1
- GitHub Actions: Don't run scheduled tasks on forked repos
- Using kdiff3 as diff tool, user has to specify name of output file after merge
- cygwin CI build hangs for 6 hours then fails HOT 5
- warning C4459 in MSVC with /W4 HOT 1
- Does not compile with clang13 due to -Werror/-Wdeprecated-copy-with-dtor HOT 2
- Ninja + Catch2 + mingw64
- "Unable to create directory" - unable to run test build with mingw provided by qt-installer HOT 5
- with CppUTest: `ApprovalMismatchException` suppresses other tests output HOT 4
- add `code -d {Received} {Approved}` to Reporters list
- Catch2 integration does not handle Generators inside sections HOT 1
- Catch2 v3 integration HOT 5
- Bug with {fmt} integration HOT 2
- CLion reporter does not open correctly if CLion is already open
- In-lining test output (as opposed to saving in files) HOT 4
- Support for catch2 v3.x.x HOT 2
- Diffing tool is never prompted to open HOT 13
- Impossible to use UNC filename in TemplatedCustomNamer [`removeRedundantDirectorySeparators()` breaks use of UNC paths, which contain `\\`] HOT 5
- _mkdir fails when asked to create more than one directory HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from approvaltests.cpp.