Mock TypeError custom override about orval HOT 7 CLOSED

@soartec-lab assigned this to you as you fixed the original ticket.

from orval.

I'll test it as the release is out there.
To clarify the issue:

With the return type now added to the .msw.ts file, the type check is more strict.
As an example, if the Schema of Dog has an literal or enum as a return value, orval uses the following code:

faker.helpers.arrayElement([
    faker.helpers.arrayElement(Object.values(DogType)),   // DogType is not imported
    undefined,
  ])

This is great.

But if you want to override this value with the override function we can not type the enum. As an example in the config we currently have.

override: {
	operations: {
		api_countries_get_collection: {
			mock: {
				data: () => {
					const countries = ["GB"] // We limit the Enum list here due to testing security

					return countries
				}
			},
		},
	},
}

The expected return type is a list of enum.

In the previous version this would result in no errors. With the strict return type the countries const now types to a string.
And we have no way to update this to a typed value as the config uses common js.

Hope this clarifies the issue.

from orval.

Similar to #1201

from orval.

@dipsaus9
Thank you for made this report.
I would like to understand this problem correctly, so could you please tell me the error message that is output?

from orval.

I have fixed the issue where it did not work correctly by #1205 when enum types were included.

from orval.

Hi, @dipsaus9

Since we released "v6.25.0" this issue has been fixed 👍

from orval.

@soartec-lab Release v6.25.0 did not fix our issue.
I opened a PR that can be a fix #1229

from orval.