Zod: only generates 200 response bodies about orval HOT 15 CLOSED

@Priddles is it just a matter of looping over the responses array and generating for each?

Yes, I'd say so.

Some level of deduplication would be good, but definitiely a nice-to-have.

from orval.

Ok assigned the ticket to you.

from orval.

Yes @TommoLeedsy PR would be great.

from orval.

Let me find out

from orval.

Similar to this issue: #1280

from orval.

Isn't this https://orval.dev/reference/configuration/output#generateeachhttpstatus

The setting to generate for each HTTP status?

from orval.

@melloware That is a config option for the mocks, and it does not affect zod generation as far as I can tell.

from orval.

Reopened i thought it did it for mocks and zod. I see now its just mocks.

from orval.

You are right the code is only doing 200

const response = spec?.[verb]?.responses?.['200'] as
    | ResponseObject
    | ReferenceObject;

from orval.

@Priddles is it just a matter of looping over the responses array and generating for each?

from orval.

@melloware I have a fix for this locally and will put a PR in tomorrow.

from orval.

@melloware @TommoLeedsy Thanks for the quick turnaround!

I saw it got released so I tried it out, but having some issues. Wasn't sure whether to open a new issue or not so putting it here.

I have a minimal reproducible example here.

The issues are:

1. It seems to be reading the config from the wrong object.
2. It generates a lot of MSW and Faker related code that has nothing to do with Zod.

from orval.

I would open a new ticket.

from orval.

@Priddles Sorry yeah that's my mistake, I didn't realise I needed to add a new config option and just used an existing one instead. I have now added generateEachHttpStatus to the zod options. This should sort it. I can put a PR in today?

from orval.

@melloware Do you know when the fix might be released?

from orval.