Git Product home page Git Product logo

Comments (7)

melloware avatar melloware commented on June 17, 2024 1

Maybe somehow you can detect whether its a matrix of values and add the numbers if not don't add the number? I think I was just lazy and started at +1 etc to fix that issue.

from orval.

melloware avatar melloware commented on June 17, 2024 1

Soon.. I will close this for now I marked it for 6.28.0

from orval.

Georgegriff avatar Georgegriff commented on June 17, 2024 1

Turns out i can't read git history.. it's already out in 6.28.2.

Just wanted to say thanks for this project, its great! Got my team out of apollo/graphql hell and back to shipping features, thanks to you and all the maintainers

from orval.

melloware avatar melloware commented on June 17, 2024

@Georgegriff that was introduced because of this issue: #1027

A PR to fix both your current scenario but not break #1027 would be great!

from orval.

Georgegriff avatar Georgegriff commented on June 17, 2024

I'll see what I can do, it might be tricky to fix without a breaking change if it results it people's exported Zod variables being renamed 🤔 an option wouldn't feel right. I'll explore it anyway and see what's possible

from orval.

Georgegriff avatar Georgegriff commented on June 17, 2024

So i just did some digging, cloned the repo and was about to start then realised @anymaniax fixed my exact issue in #1330 🥳

I confirmed it by running the yarn run generate:zod and comparing the version i'm using:

6.27.1
image
vs master
image

When do you expect this might be released?

I note that @anymaniax mentioned this is a breaking change, i do tend to agree... however the original fix that introduced the unstable variable names was introduced in a 6.x minor version too and that too technical broke variable names, so maybe it doesn't matter.

from orval.

melloware avatar melloware commented on June 17, 2024

Nice!

from orval.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.