andydbc / hologramshader Goto Github PK

i cant find the install on the unity page or github

I was trying out your shader (Absolutely amazing, by the way) and I noticed that when an object moved with the shader applied, it would cause the scanlines on the hologram to stay where they are relative to world space, ruining the hologram effect on fast moving objects.
I wanted to try and fix it myself and then make a PR to your repository but I have no experience in HLSL. So, while I did manage to hack a "fix" in there, I think there should be a better solution compared to what I did.

Here is my workaround to the problem:

I changed
o.worldVertex = mul(unity_ObjectToWorld, v.vertex);
To:
o.worldVertex = v.vertex

This fixed the problem but the scanlines appeared a lot bigger now since the scanlines' size is now depended on the object's size. So to "fix" that I multiplied v.vertex by 8 and that seemed to get the same visual effect, except now I can rotate and move the object around without the scan lines moving around. It does appear to introduce slight problems with lighting, though.

I hope you can/want to do something with this information to make a fix that is a bit less hacky than what I did.

An asset in Unity AssetStore below seems using codes from here. Please check.
https://assetstore.unity.com/packages/vfx/shaders/simple-hologram-shader-120065

Hello!

I'm a graphic designer and I like to support open source projects. I would like to design a logo for your project if you interested, I will be happy to work with you! :)

Best Regards

Baran Pirinçal

Graphic Designer

There's a D3D11 error when opening the project that will make Unity shutdown, and the shader itself also seems like it doesn't quite work. Haven't managed to get the scanlines working, but not being able to use the Demo scene doesn't allow me to say for sure, I haven't set it up wrong. The shader itself will somewhat work though (without scanlines).

Tested on 2020.3.32f1 LTS but I assume the problem is there in newer versions too, not sure in what version the issues started.