ndk-stack does not work with 64-bit binaries about ndk HOT 15 CLOSED

No, but we should prioritize this. We have a new hire coming soon, and this would make a good starter project.

from ndk.

cool!!!! r16 has fixed this.

from ndk.

Still the same problem with r13

from ndk.

@DanAlbert is there any updates on that?

from ndk.

from ndk.

i suspect the best way forward here is to kill the existing ndk-stack and switch to the "stack" script we use internally (suitably adjusted to work with the NDK rather than the platform tools). anyone good at python can probably take stack, stack_core.py, and symbol.py from https://android.googlesource.com/platform/development.git/+/master/scripts/ and send us the diff.

obviously if you're on Windows there's probably a bit more work involved, .

other than this regular expression (which doesn't seem like it would lead to the error folks are seeing)...

static const char _frame_header[] = "\\#[0-9]+[ |\t]+[pc|eip]+:*[ |\t]+([0-9a-f]{8})*";

https://cs.corp.google.com/android/ndk/sources/host-tools/ndk-stack/ndk-stack-parser.c?l=74
...i took another look at ndk-stack and still don't see any obvious problem (unless somehow the libbfd it's linking against doesn't contain the LP64 arches, but i also didn't see where anything like that was configured).

anyway, anyone with a bit of time and some python ought to be able to switch us over to the platform tool (which even has tests!).

from ndk.

@DanAlbert is there any updates on that?

from ndk.

No, unfortunately. We're still working on actually filling that new hire slot. It might happen in the r16 time frame, but almost certainly not for beta 1.

from ndk.

Any updates/progress on that? Have you filled a new hire slot? Are there any workarounds I could use until official fix comes? I currently have a stack trace reported by a client on 64-bit samsung device and I am unable to symbolificate it using ndk-stack. Any help would be appreciated!

from ndk.

see "anyone with a bit of time and some python ought to be able to switch us over to the platform tool (which even has tests!)" above. we should have someone starting next month, and what better introduction to the life than deleting ancient ndk-specific cruft and replacing it with the thing we use in the platform?

from ndk.

Yep, should be able to make this happen for r16.

from ndk.

FWIW: On my 64-bit Linux machine, ndk-stack already handles ARM64.

I see these lines in build-ndk-stack.sh:

if [ "$HOST_OS" != "darwin" -a "$DARWIN" != "yes" ]; then
    LDFLAGS=$LDFLAGS" -Wl,-gc-sections"
else
    # In darwin libbfd has to be built with some *linux* target or it won't understand ELF
    # Disable -Werror because binutils uses deprecated functions (e.g. sbrk).
    EXTRA_CONFIG="-target=arm-linux-androideabi --disable-werror"
fi

I think the Linux ndk-stack is being configured to work with host binaries, which are 64-bit. Maybe the 32-bit triple arm-linux-androideabi configures the macOS ndk-stack to handle only 32-bit binaries, so changing the target (to aarch64-linux-android?) might fix this issue on macOS?

I wonder about the Windows ndk-stack.

I'm still looking at replacing ndk-stack with the platform stack script, though.

from ndk.

Fix was merged into r16.

from ndk.

Yes.

from ndk.

r16b can do it

from ndk.