Git Product home page Git Product logo

Comments (8)

DanAlbert avatar DanAlbert commented on July 2, 2024 1

I'll defer to the LLVM folks on whether or not that's innocuous enough to cherry-pick to r27. It's already in QA, so the bar for cherry-picks of non-regressions has gone up.

from ndk.

pirama-arumuga-nainar avatar pirama-arumuga-nainar commented on July 2, 2024 1

https://android-review.googlesource.com/c/toolchain/llvm_android/+/3042676 is the cherry-pick to AOSP clang. Let's see if it passes presubmit and tests.

The fix seems reasonable. However, since this is not a regression, it doesn't meet the bar for a compiler respin. If there is another bug in the compiler that requires updating the r27 clang, we'll include the fix for this as well.

from ndk.

appujee avatar appujee commented on July 2, 2024

It doesn't look like a regression from previous compiler: https://godbolt.org/z/P8j4GnhYE This has been fixed recently in upstream clang.

from ndk.

yujincheng08 avatar yujincheng08 commented on July 2, 2024

@appujee yes, and i have bisected the commit that fixed this issue. so maybe we need to cherry-pick this fix.

from ndk.

pirama-arumuga-nainar avatar pirama-arumuga-nainar commented on July 2, 2024

a0e1cc0aefbc mentioned in the original report is the back port to the llvm-18 branch. a0b6747804e466 is the patch to the main branch of llvm-project.

from ndk.

yujincheng08 avatar yujincheng08 commented on July 2, 2024

So is it possible to pick it to r27?

from ndk.

DanAlbert avatar DanAlbert commented on July 2, 2024

(and there almost always is another bug, so it's likely)

from ndk.

yujincheng08 avatar yujincheng08 commented on July 2, 2024

Confirmed 28.0.11744028 works.

from ndk.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.