[BUG] clang frontend crashes on NDK 27.0.11718014 about ndk HOT 9 CLOSED

(Thanks for proactively pursuing this in upstream and getting it fixed, btw!)

from ndk.

(Thanks for proactively pursuing this in upstream and getting it fixed, btw!)

+1. We're very appreciative of the work you've done to help us, here and on quite a few other bugs :)

from ndk.

The fix for this bug was cherry-picked and will be part of r27 to be released later this month.

from ndk.

Reproduces in ToT clang from today (c54657887b) as well:

clang++: /usr/local/google/work/llvm-monorepo/llvm-project/clang/lib/AST/Decl.cpp:2561: APValue *clang::VarDecl::evaluateValueImpl(SmallVectorImpl<PartialDiagnosticAt> &, bool) const: Assertion `!Init->isValueDependent()' failed.
PLEASE submit a bug report to https://github.com/llvm/llvm-project/issues/ and include the crash backtrace, preprocessed source, and associated run script.

Reproducer fails with errors on r26.

from ndk.

Non-regression and pretty late in the r27 cycle (and nothing available to cherry-pick yet), so planned for r28. We'll consider a cherry-pick into an r27 minor release if there's a low impact fix from upstream when the time comes.

from ndk.

this is actually a regression, see llvm/llvm-project#93828. the crash shown by @pirama-arumuga-nainar is another crash.

I replaced lines ranging from 85898 to 85912 with

    constexpr T&& operator [](uint i)&& noexcept
    {
      return move(Data[i]);
    }
    constexpr T const& operator [](uint i) const& noexcept
    {
      return Data[i];
    }
    constexpr T& operator [](uint i)& noexcept
    {
      return Data[i];
    }

and ndk 27 crashes while ndk 26 compiles.

from ndk.

Oh, sorry about that, I misunderstood. Thanks for clarifying 👍

In that case, we're still pretty dependent on upstream to provide the fix, but if one becomes available we'll aim to do a minor release for it rather than only picking it up opportunistically (there are always exceptions if the fix is invasive and likely to do more harm than good, but that's very rare).

from ndk.

upstream fixed: llvm/llvm-project@3d361b2

from ndk.

This is unlikely to make it to RC1. We can take it the next time we update the compiler in r27. (As we prep the next clang update, we also need to create a release branch for the r27 clang to be able to get new prebuilts.)

from ndk.