Deion When I try the ci version (see <a href="https://ci.and

Submitted a bug report to upstream: <a class="issue-link js-issue-link" data-error-tex

I check out to e4a4122eb6768b69640173b4c32fd88de4547227: <a class="issue-link js-issue

<a class="user-mention notranslate" data-hovercard-type="user" data-hovercard-url="/us

[Bug] clang frontend crashes on NDK 28.0.11617993 about ndk HOT 11 OPEN

yujincheng08 commented on August 22, 2024

[Bug] clang frontend crashes on NDK 28.0.11617993

from ndk.

Comments (11)

DanAlbert commented on August 22, 2024 1

Reopening because I haven't updated the changelog (I didn't know the cherry-pick ever got done, thanks for confirming!)

https://android-review.googlesource.com/c/platform/ndk/+/3037382, but needs to be cherry-picked, and I can't do that yet.

from ndk.

pirama-arumuga-nainar commented on August 22, 2024

This is also broken with ToT. Building with assertions enabled, I get:

clang: /usr/local/google/work/llvm-monorepo/llvm-project/clang/lib/AST/ExprConstant.cpp:15798: bool clang::Expr::EvaluateAsConstantExpr(EvalResult &, const ASTContext &, ConstantExprKind) const: Assertion `!isValueDependent() && "Expression evaluator can't be called on a dependent expression."' failed.
...
1.      D:/Android/Projects/LSPosed/external/lsplant/lsplant/src/main/jni/include/utils/jni_helper.hpp:179:61: current parser token ';'                                                                           
2.      D:/Android/Projects/LSPosed/external/lsplant/lsplant/src/main/jni/include/utils/jni_helper.hpp:18:1: parsing namespace 'lsplant'                                                                  
3.      D:/Android/Projects/LSPosed/external/lsplant/lsplant/src/main/jni/include/utils/jni_helper.hpp:178:64: parsing function body 'lsplant::JNI_NewStringUTF'                                                  
4.      D:/Android/Projects/LSPosed/external/lsplant/lsplant/src/main/jni/include/utils/jni_helper.hpp:178:64: in compound statement ('{}')

from ndk.

DanAlbert commented on August 22, 2024

Since this is a regression, triaging for r27. Since it's not fixed upstream yet, it probably won't be fixed in beta 1, but we can still pick it up in beta 2 or RC 1.

from ndk.

pirama-arumuga-nainar commented on August 22, 2024

This works in clang-r510928. So the bisect window is between r510928 and r522817.

from ndk.

yujincheng08 commented on August 22, 2024

~~Confirmed this is caused by concept. Maybe it's fixed by llvm/llvm-project#83997?~~

Never mind. I picked this PR but it still crashes.

from ndk.

yujincheng08 commented on August 22, 2024

Submitted a bug report to upstream: llvm/llvm-project#86769

from ndk.

ZijunZhaoCCK commented on August 22, 2024

I check out to e4a4122eb6768b69640173b4c32fd88de4547227: llvm/llvm-project#71040 and can reproduce the crash. And this works in its last commit: e9db60c05e2fb96ff40cbb1f78790abc5de9237e llvm/llvm-project#70991 .

from ndk.

yujincheng08 commented on August 22, 2024

@ZijunZhaoCCK Please see this: llvm/llvm-project#86914

from ndk.

yujincheng08 commented on August 22, 2024

@DanAlbert @pirama-arumuga-nainar fixed by upstream: llvm/llvm-project@0f6ed4c

from ndk.

pirama-arumuga-nainar commented on August 22, 2024

@ZijunZhaoCCK please cherry-pick llvm/llvm-project@0f6ed4c to llvm-toolchain.

from ndk.

yujincheng08 commented on August 22, 2024

confirmed fixed in 28.0.11699160