Git Product home page Git Product logo

Comments (7)

grs avatar grs commented on June 25, 2024

Yes that is correct, the properties are all top level objects. There is some tension between closely following the spec and making the library intuitive for users who don't know the spec. The properties were one such trade-off. (At one point rhea supported both, but that ended up being more confusing)

from rhea.

amarzavery avatar amarzavery commented on June 25, 2024

Oops. Can this be documented in the README.md? This would help other people. Typescript type definitions would have been so useful in this case.
Thank you so much for all the prompt responses.

from rhea.

amarzavery avatar amarzavery commented on June 25, 2024

/cc @anthonyvercolano - message_id will be a top level property.

from rhea.

grs avatar grs commented on June 25, 2024

The README.md does briefly describe the message fields in text for Sender.send(). Would probably be clearer to have a distinct section on message format and refer to that from relevant places.

from rhea.

amarzavery avatar amarzavery commented on June 25, 2024

@grs - Some follow up questions:

  • How should predefined properties actually be serialized on the wire? Does message_id go under properties (rhea does it for us)? or it actually remains as a top level property on the wire as well?
  • What about application_properties and message_annotations? Should they be flattened as well or should remain inside their property names?

I am still a newbie with AMQP hence some of those questions may seem silly..

from rhea.

grs avatar grs commented on June 25, 2024

rhea will encode everything correctly on the wire i.e. properties will be in a proper properties section.

application-properties and message-annotations are in nested maps as the names of those are not known in advance

from rhea.

amarzavery avatar amarzavery commented on June 25, 2024

cool that makes sense. Thank you :).

from rhea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.