Git Product home page Git Product logo

Comments (7)

grs avatar grs commented on June 26, 2024 1

Yes, though you can set it to a javascript Date object.

from rhea.

grs avatar grs commented on June 26, 2024 1

Yes, you are correct that support for setting it as a Date object is not available on 1.0.2, where you must set it as the millisecs from epoch (i.e. the value returned by getTime() on the date object).

from rhea.

vishnureddy17 avatar vishnureddy17 commented on June 26, 2024

great, thank you! closing this issue for now, but I do think it'd be useful to specify that somewhere such as in the typescript comment. At least for now, someone can search github issues for this answer.

from rhea.

vishnureddy17 avatar vishnureddy17 commented on June 26, 2024

Also, is setting it to a JavaScript date object supported in 1.0.24? The typescript for that version says number for absolute_expiry_time. Reopening for this outstanding question.

from rhea.

grs avatar grs commented on June 26, 2024

I believe so as the tests use the typescript interface: e.g. https://github.com/amqp/rhea/blob/main/test/messages.ts#L247

from rhea.

vishnureddy17 avatar vishnureddy17 commented on June 26, 2024

From my understanding of the commit history, it seems like the corresponding test for 1.0.24 do not use a JavaScript Date object.

Here is a link to the test at the commit where the package.json version was bumped to 1.0.24:
https://github.com/amqp/rhea/blob/2cbe55795b86a43375111f2f446089f55b948ecf/test/messages.ts

Could you clarify what the implication of this is in terms of Date object support on this specific version (1.0.24)? I just want to make sure we are using rhea correctly in production.

Thanks again!

from rhea.

vishnureddy17 avatar vishnureddy17 commented on June 26, 2024

Great, thank you!

from rhea.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.