Sender appears to be ignoring max_frame_size about rhea HOT 4 OPEN

Are you waiting for the connection to be opened before sending?

from rhea.

Thanks so much for the help @grs - this appears to have been the problem.

I previously had:

// snip - set up connection
connection.connect();
sender.open();
sender.send(message);

Which appears to work somewhat - the message is sent successfully, as long as it doesn't exceed max_frame_size of the server.

I've now changed it to:

// snip - set up connection
connection.connect();
sender.open();
sender.once('sendable', () => {
    sender.send(message);
});

Now it picks up the max_frame_size from the server side and splits the large message up correctly.

All that being said - I think there is a problem here. Shouldn't I be able to set the max_frame_size on the connection myself?

This test case fails for me:

const container = require('rhea');

describe('Connection Options', () => {
  it('should set max_frame_size', () => {
    let connection;
    try {
      connection = container.connect({ host: '127.0.0.1', port: 5672, max_frame_size: 1000 });
      expect(connection.max_frame_size).toBe(1000);
    } finally {
      if (connection) {
        connection.close();
      }
    }
  });
});

I feel like if I'm not supposed to set max_frame_size on the client side, then it shouldn't be an option in the library, and if I'm allowed to set it then it should be honoured.

Again, I really appreciate the help!

from rhea.

Each side sets its max-frame-size independently. So if you set it on your connection, that is the max frame size that the broker is allowed to send to you. You cannot alter the max-frame-size the broker will accept by setting the value on your side of the connection. (If that is something that can be configured it would be configured on the broker side)

from rhea.

Ah that makes sense. Thanks again!

Perhaps it could be named something like max_receive_frame_size, or have a comment indicating this.

from rhea.