Git Product home page Git Product logo

shrink-ray's People

Contributors

aickin avatar alorel avatar basarat avatar codeiter avatar debanjanbasu avatar dougwilson avatar fishrock123 avatar glenjamin avatar greenkeeper[bot] avatar greenkeeperio-bot avatar jonathanong avatar juancho1 avatar lscoder avatar scttdavs avatar semantic-release-bot avatar snyk-bot avatar stfsy avatar sylvaindumont avatar yomed avatar zetlen avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar

shrink-ray's Issues

Abandoned node-zopfli package causes installation failures

Due to https://github.com/pierreinglebert/node-zopfli apparently being abandoned and consequently pierreinglebert/node-zopfli#87, it is becoming very difficult to install shrink-ray-current locally or in production without fatal errors.

I've been able to work around this because my cloud hosting provider has the bindings and the compiled binaries cached; however, this is not a long-term solution.

If, with the community's help, we can identify the outstanding issues with the node-zopfli package, I would be willing to create a fork and publish releases via GitHub Releases, so that it stops messing with this package.

Alternatively, I would suggest removing node-zopfli from this package to avoid the installation issue. Given that zopfli is only useful for static assets, it might not be such a big deal for users to remove.

Thoughts?

An in-range update of @types/node is breaking the build 🚨

Version 10.7.0 of @types/node was just published.

Branch Build failing 🚨
Dependency @types/node
Current Version 10.5.8
Type dependency

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/@types/node-10.7.0 at 99.074% (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of supertest is breaking the build 🚨

Version 3.3.0 of supertest was just published.

Branch Build failing 🚨
Dependency supertest
Current Version 3.2.0
Type devDependency

This version is covered by your current version range and after updating it in your project the build failed.

supertest is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/supertest-3.3.0 at 99.074% (Details).

Release Notes v3.3.0

#509 - Fix #486, bug in _assertBody, switch to deepStrictEqual (thanks @mikelax)
#510 - Refactor test files to use const/let (thanks @rimiti)

Commits

The new version differs by 10 commits.

  • e910e85 chore: Prepare for v3.3.0 release.
  • bd864de Merge pull request #511 from visionmedia/bugfix-486-equal
  • 101fbf5 Merge branch 'master' into bugfix-486-equal
  • 04230bb Merge pull request #510 from visionmedia/refact-const-let
  • 510a7ae bugfix: 486 Change method to use deepStrictEqual. (#509)
  • 913150d chore(.editorconfig) [*.md] block removed
  • 82e0828 refact(test/supertest.js) vars replaced by const and let
  • 5443136 chore(.editorconfig) configuration file created
  • 7233ba6 chore(.eslintrc) parserOptions option added to use es6
  • 322ebf6 bugfix: 486 Change method to use deepStrictEqual.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of mocha is breaking the build 🚨

The devDependency mocha was updated from 6.0.2 to 6.1.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

mocha is a devDependency of this project. It might not break your production code or affect downstream projects, but probably breaks your build or test tools, which may prevent deploying or publishing.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/mocha-6.1.0 at 99.071% (Details).

Release Notes for v6.1.0

6.1.0 / 2019-04-07

πŸ”’ Security Fixes

  • #3845: Update dependency "js-yaml" to v3.13.0 per npm security advisory (@plroebuck)

πŸŽ‰ Enhancements

  • #3766: Make reporter constructor support optional options parameter (@plroebuck)
  • #3760: Add support for config files with .jsonc extension (@sstephant)

πŸ“  Deprecations

These are soft-deprecated, and will emit a warning upon use. Support will be removed in (likely) the next major version of Mocha:

πŸ› Fixes

  • #3829: Use cwd-relative pathname to load config file (@plroebuck)
  • #3745: Fix async calls of this.skip() in "before each" hooks (@juergba)
  • #3669: Enable --allow-uncaught for uncaught exceptions thrown inside hooks (@givanse)

and some regressions:

πŸ“– Documentation

πŸ”© Other

  • #3830: Replace dependency "findup-sync" with "find-up" for faster startup (@cspotcode)
  • #3799: Update devDependencies to fix many npm vulnerabilities (@XhmikosR)
Commits

The new version differs by 28 commits.

  • f4fc95a Release v6.1.0
  • bd29dbd update CHANGELOG for v6.1.0 [ci skip]
  • aaf2b72 Use cwd-relative pathname to load config file (#3829)
  • b079d24 upgrade deps as per npm audit fix; closes #3854
  • e87c689 Deprecate this.skip() for "after all" hooks (#3719)
  • 81cfa90 Copy Suite property "root" when cloning; closes #3847 (#3848)
  • 8aa2fc4 Fix issue 3714, hide pound icon showing on hover header on docs page (#3850)
  • 586bf78 Update JS-YAML to address security issue (#3845)
  • d1024a3 Update doc examples "tests.html" (#3811)
  • 1d570e0 Delete "/docs/example/chai.js"
  • ade8b90 runner.js: "self.test" undefined in Browser (#3835)
  • 0098147 Replace findup-sync with find-up for faster startup (#3830)
  • d5ba121 Remove "package" flag from sample config file because it can only be passes as CLI arg (#3793)
  • a3089ad update package-lock
  • 75430ec Upgrade yargs-parser dependency to avoid loading 2 copies of yargs

There are 28 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

CPU Performance issues running shrink-ray instead of compression

Will give a better repro once we have untangled it from prop software.

Env: Dual-core AWS instance Ubuntu 16.04 instance running a nodev8.9.0, Express 4.x
Repro (WIP): Consistently high CPU usage after hitting a route (that returns a large but not unreasonable amount of data) once every 3 seconds.

Just want to give other users a heads up.

An in-range update of @types/node is breaking the build 🚨

The dependency @types/node was updated from 12.12.1 to 12.12.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of compressible is breaking the build 🚨

The dependency compressible was updated from 2.0.16 to 2.0.17.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

compressible is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/compressible-2.0.17 at 99.071% (Details).

Release Notes for 2.0.17
  • deps: mime-db@'>= 1.40.0 < 2'
Commits

The new version differs by 11 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Comma is inserted into the encoded text

When compressing an xml file (probably other formats as well) with all 3 schemes (br, gzip, deflate) a "," is inserted into the text:

abc-0 abc-1 abc-2 abc-3 ... abc-564 abc-565 abc-566 **abc-567** abc-568 abc-569 false

When switching off the middleware it did not happen.

This is how to repro:

const express = require("express");
const app = express();
const port = 3000;
const querystring = require("querystring");
const shrinkRay = require("shrink-ray-current");

app.use(shrinkRay());

app.get("/xml/:size", (req, res) => {
  let xml = '<?xml version="1.0" encoding="UTF-8"?>';
  xml += "<foo>";
  for (let i = 0; i < req.params.size; ++i) {
    xml += `<bar naaa="foo">abc-${i}</bar>`;
  }
  xml += `<bar>false</bar>`;
  xml += "</foo>";
  res.header("Content-Type", "application/xml");
  res.status(200).send(xml);
});

app.listen(port, () => {
  console.log(`Example app listening on port ${port}`);
});

An in-range update of compressible is breaking the build 🚨

The dependency compressible was updated from 2.0.17 to 2.0.18.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

compressible is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Commits

The new version differs by 41 commits.

There are 41 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Cache: only re-encode if maximum quality wasn't used originally

It seems that this module will asynchronously re-encode at the best/maximum quality, even if the maximum quality was used originally. IIUC, this means that if you ask for the maximum quality, shrink-ray will end up compressing the resource twice at the maximum quality.

I think we need to add a guard around the re-encode, so that it only runs if maximum quality wasn't already used:

shrink-ray/index.js

Lines 411 to 422 in f7cfcc7

// now asynchronously re-encode the entry at best quality
const result = new BufferWritable();
new BufferReadable(buffer)
.pipe(getBestQualityReencoder(coding, zopfli))
.pipe(result)
.on('finish', function () {
const itemInCache = lru.peek(key);
if (itemInCache) {
itemInCache.buffer = result.toBuffer();
}
});

Lots of deprecated sub-dependencies

Seeing this when I npm i shrink-ray-current

npm WARN deprecated [email protected]: this library is no longer supported
npm WARN deprecated [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
npm WARN deprecated [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
npm WARN deprecated [email protected]: The zlib module provides APIs for brotli compression/decompression starting with Node.js v10.16.0, please use it over iltorb

By the way, most of these were present when I tried npm i shrink-ray, but some much more there.

Types: ShrinkRayOptions.filter should be optional

Hello and thank you for your work.

I noticed that when I want to pass some options, I'm required to provide filter even when I have no custom filter to provide.

Offending code

app.use(
  shrinkRay({
    brotli: {
      mode: 11,
    },
  }),
);

Error message:

Argument of type '{ brotli: { mode: number; }; }' is not assignable to parameter of type 'ShrinkRayOptions'.
  Property 'filter' is missing in type '{ brotli: { mode: number; }; }' but required in type 'ShrinkRayOptions'.ts(2345)

Workaround

I could do this:

app.use(
  shrinkRay({
    brotli: {
      mode: 11,
    },
    filter: shrinkRay.filter,
  }),
);

but it strikes me as awkward and slightly redundant since adding filter: shrinkRay.filter doesn't affect the functionality in any way.

Solution

This:

interface ShrinkRayOptions extends Filterable {

should be changed to:

- interface ShrinkRayOptions extends Filterable {
+ interface ShrinkRayOptions extends Partial<Filterable> {

What do you think?

caching function example

First off, thank you so much for the time you have put into this keeping it up to date.

As a very new user to node world, one thing I experienced was wondering how a cache function would actually look:

If you serve a large number of dynamic files with ETags, you may want to have your cache function restrict caching to your static file directory so as to avoid thrashing the cache and wasting CPU time on expensive compressions.

I think it would be helpful to show an example of that cache function so users could tweak it. Would it be something like this?

app.use(shrinkRay({cache: shouldCache}));
 
function shouldCache(req, res) {
  if(!req.url.startsWith('/static/') {
      // Don't compress responses that are not static
      return false;
  }
  // fallback to standard cache function
  return shrinkRay.cache(req, res);
}

An in-range update of @types/node is breaking the build 🚨

The dependency @types/node was updated from 11.13.7 to 11.13.8.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/@types/node-11.13.8 at 99.071% (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

An in-range update of @types/node is breaking the build 🚨

The dependency @types/node was updated from 12.6.9 to 12.7.0.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).
  • βœ… coverage/coveralls: First build on greenkeeper/@types/node-12.7.0 at 99.155% (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Node v16.2.0 Fails To Install Shrink-Ray-Current On Windows 10

Attempting to install dev dependencies with node version 16.2.0 or higher results in the following error with the package iltorb which has been archived / abandoned.

npm ERR! code 1
npm ERR! path E:\Repos\x\node_modules\iltorb
npm ERR! command failed
npm ERR! command C:\Windows\system32\cmd.exe /d /s /c node ./scripts/install.js || node-gyp rebuild
npm ERR! info install installing standalone, skipping download.
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | win32 | x64
npm ERR! gyp ERR! configure error
npm ERR! gyp ERR! stack Error: Command failed: C:\Python39\python.EXE -c import sys; print "%s.%s.%s" % sys.version_info[:3];
npm ERR! gyp ERR! stack   File "<string>", line 1
npm ERR! gyp ERR! stack     import sys; print "%s.%s.%s" % sys.version_info[:3];
npm ERR! gyp ERR! stack                       ^
npm ERR! gyp ERR! stack SyntaxError: invalid syntax
npm ERR! gyp ERR! stack
npm ERR! gyp ERR! stack     at ChildProcess.exithandler (node:child_process:326:12)
npm ERR! gyp ERR! stack     at ChildProcess.emit (node:events:365:28)
npm ERR! gyp ERR! stack     at maybeClose (node:internal/child_process:1067:16)
npm ERR! gyp ERR! stack     at Process.ChildProcess._handle.onexit (node:internal/child_process:301:5)
npm ERR! gyp ERR! System Windows_NT 10.0.19043
npm ERR! gyp ERR! command "C:\\Program Files\\nodejs\\node.exe" "E:\\Repos\x\\node_modules\\iltorb\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild"
npm ERR! gyp ERR! cwd E:\Repos\x\node_modules\iltorb
npm ERR! gyp ERR! node -v v16.2.0
npm ERR! gyp ERR! node-gyp -v v3.8.0
npm ERR! gyp ERR! not ok

cache | time limit

Hi!,

how does one tell the cache to only be valid for a certain amount of time? I only see the option to set a max. cache size πŸ˜€

Caching

Hello everyone. First of all I wanna say that this is a great module and I'm definitely using this in our node-express production app and I thank all of them involved in making this possible. I don't have an issue, but rather a question, which is, when the module says files are asynchronously cached for subsequent requests, is this server-side or client-side caching. I'm a total newbie in this area and am trying to understand how all this fits into the server-browser ecosystem and if anyone could shed some light on this topic it would be immensely appreciative. Thanks!

Likely memory leak

Just did a release that swapped compression for "shrink-ray-current": "4.1.2", and this is the resulting memory (auto restart on a max memory limit drops it down)

Screen Shot 2020-01-17 at 9 48 58 AM

An in-range update of node-zopfli-es is breaking the build 🚨

The dependency node-zopfli-es was updated from 1.0.1 to 1.0.2.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

node-zopfli-es is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

Commits

The new version differs by 3 commits.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

node-zopfli-es dependency error

Sudden error when deploying our app in GCP.
We are using node 18.16.0
This error did not occur this morning, it occurs suddenly in the afternoon, no changes made in the application, we just rebuild it.

npm ERR! code 1
npm ERR! path /workspace/code/node_modules/node-zopfli-es
npm ERR! command failed
npm ERR! command sh -c node-gyp rebuild
npm ERR! gyp info it worked if it ends with ok
npm ERR! gyp info using [email protected]
npm ERR! gyp info using [email protected] | linux | x64
npm ERR! gyp info find Python using Python version 3.11.2 found at "/usr/bin/python3"
npm ERR! gyp http GET https://nodejs.org/download/release/v18.16.0/node-v18.16.0-headers.tar.gz
npm ERR! gyp http 200 https://nodejs.org/download/release/v18.16.0/node-v18.16.0-headers.tar.gz
npm ERR! gyp http GET https://nodejs.org/download/release/v18.16.0/SHASUMS256.txt
npm ERR! gyp http 200 https://nodejs.org/download/release/v18.16.0/SHASUMS256.txt
npm ERR! (node:77) [DEP0150] DeprecationWarning: Setting process.config is deprecated. In the future, the property will be read-only.
npm ERR! (Use `node --trace-deprecation ...` to show where the warning was created)
npm ERR! gyp info spawn /usr/bin/python3
npm ERR! gyp info spawn args [
npm ERR! gyp info spawn args '/workspace/code/node_modules/node-gyp/gyp/gyp_main.py',
npm ERR! gyp info spawn args 'binding.gyp',
npm ERR! gyp info spawn args '-f',
npm ERR! gyp info spawn args 'make',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/workspace/code/node_modules/node-zopfli-es/build/config.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/workspace/code/node_modules/node-gyp/addon.gypi',
npm ERR! gyp info spawn args '-I',
npm ERR! gyp info spawn args '/builder/home/.cache/node-gyp/18.16.0/include/node/common.gypi',
npm ERR! gyp info spawn args '-Dlibrary=shared_library',
npm ERR! gyp info spawn args '-Dvisibility=default',
npm ERR! gyp info spawn args '-Dnode_root_dir=/builder/home/.cache/node-gyp/18.16.0',
npm ERR! gyp info spawn args '-Dnode_gyp_dir=/workspace/code/node_modules/node-gyp',
npm ERR! gyp info spawn args '-Dnode_lib_file=/builder/home/.cache/node-gyp/18.16.0/<(target_arch)/node.lib',
npm ERR! gyp info spawn args '-Dmodule_root_dir=/workspace/code/node_modules/node-zopfli-es',
npm ERR! gyp info spawn args '-Dnode_engine=v8',
npm ERR! gyp info spawn args '--depth=.',
npm ERR! gyp info spawn args '--no-parallel',
npm ERR! gyp info spawn args '--generator-output',
npm ERR! gyp info spawn args 'build',
npm ERR! gyp info spawn args '-Goutput_dir=.'
npm ERR! gyp info spawn args ]
npm ERR! Traceback (most recent call last):
npm ERR! File "/workspace/code/node_modules/node-gyp/gyp/gyp_main.py", line 51, in <module>
npm ERR! sys

Prefer zlib over zopfli for gzip?

There was some nice work done in #36 to make iltorb and node-zopfli-es optional.

But zopfli-compat.js is preferring zopfli over zlib, and printing a warning if node-zopfli-es is not installed. zopfli may create gzip assets 5% smaller than zlib, but it is much slower (~100x).

Since shrink-ray-current is for use at runtime, speed is very important and I would prefer to use zlib not zopfli. This would be consistent with brotli-compat.js which is preferring zlib over iltorb. Would you be open to this change, or alternatively silencing the warning Module "node-zopfli-es" was unavailable?

An in-range update of @types/node is breaking the build 🚨

The dependency @types/node was updated from 12.11.2 to 12.11.3.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

@types/node is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build failed (Details).

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

GZIP fallback

Hi,

I'm getting an error
ERROR (node:1) [ZOPFLI_COMPAT] MISSING_MODULE: Module "node-zopfli-es" was unavailable Zopfli compression unavailable; will fall back to gzip.

Any tips?

The package is added through
"optionalDependencies": { "iltorb": "~2.0.0", "node-zopfli-es": "~1.0.3" },

Server push

I want to push a service worker ("/sw.js") when people land on the root ("/") but I don't understand the server-sent events to do this.

I've googled this and can't get this to work

Fails to install on node 12 macos

Description

Fails to npm install shrink-ray-current on Mac OS on

$ node -v                 
v12.12.0

with the following error

CXX(target) Release/obj.target/iltorb/src/dec/stream_decode.o
../src/dec/stream_decode.cc:14:72: error: no matching member function for call to 'ToObject'
    Local<Object> dictionary = Nan::Get(params, key).ToLocalChecked()->ToObject();
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2576:44: note: candidate function not viable: requires single argument 'context', but no arguments were
      provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
                                           ^
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2590:31: note: candidate function not viable: requires single argument 'isolate', but no arguments were
      provided
                Local<Object> ToObject(Isolate* isolate) const);
                              ^
../src/dec/stream_decode.cc:40:49: error: no matching member function for call to 'ToObject'
  StreamDecode* obj = new StreamDecode(info[0]->ToObject());
                                       ~~~~~~~~~^~~~~~~~
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2576:44: note: candidate function not viable: requires single argument 'context', but no arguments were
      provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
                                           ^
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2590:31: note: candidate function not viable: requires single argument 'isolate', but no arguments were
      provided
                Local<Object> ToObject(Isolate* isolate) const);
                              ^
../src/dec/stream_decode.cc:48:35: error: no matching member function for call to 'ToObject'
  Local<Object> buffer = info[0]->ToObject();
                         ~~~~~~~~~^~~~~~~~
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2576:44: note: candidate function not viable: requires single argument 'context', but no arguments were
      provided
  V8_WARN_UNUSED_RESULT MaybeLocal<Object> ToObject(
                                           ^
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2590:31: note: candidate function not viable: requires single argument 'isolate', but no arguments were
      provided
                Local<Object> ToObject(Isolate* isolate) const);
                              ^
../src/dec/stream_decode.cc:54:16: error: no matching member function for call to 'BooleanValue'
  if (info[2]->BooleanValue()) {
      ~~~~~~~~~^~~~~~~~~~~~
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2603:8: note: candidate function not viable: requires single argument 'isolate', but no arguments were
      provided
  bool BooleanValue(Isolate* isolate) const;
       ^
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2606:51: note: candidate function not viable: requires single argument 'context', but no arguments were
      provided
                V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
                                                  ^
../src/dec/stream_decode.cc:70:16: error: no matching member function for call to 'BooleanValue'
  if (info[1]->BooleanValue()) {
      ~~~~~~~~~^~~~~~~~~~~~
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2603:8: note: candidate function not viable: requires single argument 'isolate', but no arguments were
      provided
  bool BooleanValue(Isolate* isolate) const;
       ^
/Users/**/Library/Caches/node-gyp/12.12.0/include/node/v8.h:2606:51: note: candidate function not viable: requires single argument 'context', but no arguments were
      provided
                V8_WARN_UNUSED_RESULT Maybe<bool> BooleanValue(
                                                  ^
5 errors generated.
make: *** [Release/obj.target/iltorb/src/dec/stream_decode.o] Error 1
gyp ERR! build error 
gyp ERR! stack Error: `make` failed with exit code: 2
gyp ERR! stack     at ChildProcess.onExit (/usr/local/lib/node_modules/npm/node_modules/node-gyp/lib/build.js:196:23)
gyp ERR! stack     at ChildProcess.emit (events.js:210:5)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:272:12)
gyp ERR! System Darwin 18.7.0
gyp ERR! command "/usr/local/bin/node" "/usr/local/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "rebuild"
gyp ERR! cwd /Users/**/**/workspace/einstein-platform-console/node_modules/iltorb
gyp ERR! node -v v12.12.0
gyp ERR! node-gyp -v v5.0.3
gyp ERR! not ok 
npm WARN [email protected] requires a peer of iltorb@^2.0.0 but none is installed. You must install peer dependencies yourself.
npm WARN [email protected] requires a peer of node-zopfli-es@^1.0.3 but none is installed. You must install peer dependencies yourself.

npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] install: `detect-libc prebuild-install || node-gyp rebuild`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] install script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /Users/**/.npm/_logs/2019-10-14T20_04_48_306Z-debug.log

The installation succeeds on Node 10 and Node 11. However, fails on 12

An in-range update of accepts is breaking the build 🚨

The dependency accepts was updated from 1.3.5 to 1.3.6.

🚨 View failing branch.

This version is covered by your current version range and after updating it in your project the build failed.

accepts is a direct dependency of this project, and it is very likely causing it to break. If other packages depend on yours, this update is probably also breaking those in turn.

Status Details
  • ❌ continuous-integration/travis-ci/push: The Travis CI build could not complete due to an error (Details).

Release Notes for 1.3.6
  • deps: mime-types@~2.1.24
    • deps: mime-db@~1.40.0
Commits

The new version differs by 47 commits.

There are 47 commits in total.

See the full diff

FAQ and help

There is a collection of frequently asked questions. If those don’t help, you can always ask the humans behind Greenkeeper.


Your Greenkeeper Bot 🌴

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.