caching function example about shrink-ray HOT 2 CLOSED

Hey. The readme was copied from the original library and was largely unchanged.

The default cache function is defined as follows so your fallback would not work as shrinkRay.cache is undefined:

And as for providing examples, I really don't see much of a point:

1. Given how req + res are standard abbreviations for request + response and how the README uses those variable names, it's clear what data the function can work with.
2. The caching criteria would vary wildly from application to application; we might end up confusing the user even more if they are unable to get past the previous point.

A working version of the example you gave would look like this in its simplest form:

function shouldCache(req) {
   return req.url.startsWith('/static');
}

from shrink-ray.

Part of the confusion was my fault, I was unsure that if I didn't fall back to standard cache function I would cache files without etag or something equivalently bad. I was afraid my function would override some desired behavior but with your response and a more careful reading of the docs I see that I can return true from my override cache function without fear:

shrink-ray ... will never cache a response that does not include an ETag, even if the cache function returns true.

Phew. Thanks for your help!

from shrink-ray.