alexocode / brex Goto Github PK

Hello! I was trying to use Brex within an app using:

Erlang/OTP 22 [erts-10.7] [source] [64-bit] [smp:12:12] [ds:12:12:10] [async-threads:1] [hipe] [dtrace]

Elixir 1.10.2 (compiled with Erlang/OTP 22)

On MacOS 10.15.4

And I got an error of compilation of Brex because of a conflict on is_struct defined in Brex.Rule.Struct at line 32.

I have solved the issue and got the compiler to pass by changing it from is_struct to is_a_struct and changing the function name in that file so that there is no conflict. Do you think that it would make sense to open a PR?

When using Brex.none/1 with a dynamic set of rules, I discovered a behaviour I am unsure if it is the expected one. Check the following example:

Brex.none([])
|> Brex.evaluate(:something)
|> Brex.passed?()

No rules have been passed to Brex.none/1. I would expect true, but it currently returns false.

There is no native implementation of none? in Elixir, so I use Ruby as reference:

[].all?  # true
[].none? # true

The problem with Brex.none/1 and passing an empty list of rules is, that it passes the given rules to Brex.all/1 and inverts the result. I think we need a special handling for the case when Brex.none/1 receives an empty list of rules.

defmodule Brex.Operator.Aggregator do
  # ...

  def none?([]), do: true
  def none?(enum), do: not all?(enum)
end

What do you think? 😉