Conflict of is_struct with Kernel.is_struct about brex HOT 4 CLOSED

Instead of renaming is_struct/1 to is_a_struct/1, one could remove it and use the native is_struct/1 from Elixir.

from brex.

Removing is no option, as that would break compatibility with Elixir versions below 1.10. Also the Kernel version operates on an actual struct while the helper here operates on a module, which makes this whole point moot.

I suggest to rename to is_struct_module. If you want to open a PR that would be welcome. A PR should also update the Travis config to check for newer Elixir and Erlang combinations. I expect that certain combinations would have to be excluded because newer Elixir versions won't be compatible with older Erlang versions.

from brex.

cool @sascha-wolf , done #5

from brex.

Closed in #5

from brex.