adeora7 / hacktoberfest_progress Goto Github PK

The URL is wrapped in a code block and not making it functionally clickable.

Needs fixing or restyling to keep it prominent.

The current imagery is from last year and needs updating for 2018.

May require design knowledge and tools.

Once tests have been created, we can add a CI (free) to run checks across new PRs.

I would recommend CircleCI as it's free to integrate.

Find better format to represent contributors in the readme file. It can be a table or thumbnails etc.

Fix typos, add missing explanations, improve formatting, etc.

The messages which come back based on the results seem a little robotic.

They could do with updating to be more like the spoken word.

If the details of the Pull Requests in the results div can be showed as a popup only if someone clicks on a show details button, it will be better as now the length of the extension popup increases too much while displaying result.

Improve the UI in some way?

Make the results more prominent, improve the 'show results' overlay, better font?

Choose a modern testing framework and add coverage of the code

The font colour should either be changed to something darker like the background colour, or the text could be moved elsewhere.

When the limit is reached, a 403 forbidden error is thrown in the console.

We should handle this correctly by informing the user.

If 403 error returned when calling API, we should probably handle this better.

Suggestion: Don't change any UI unless a ~200 is returned successfully.

If I set up two separate users, two seperate users appear in the UI and clicking between them searches, but only sometimes.

Example response which causes error

{
"total_count": 0,
"incomplete_results": false,
"items": []
}

This errors as the avatar urls rely on user data being available and at least one PR existing.

Possible solution would be to have multiple calls to guarantee the user data is returned.

Thumbnails can be saved for at least 5 recently searched users for quick search. One option for design can be round images/handles right above the search box.

Remove the "pull requests" section from the result box if there are no PRs.

The commas should be removed and the results should be formatted to a list.

A sweet improvement would be for the progress bar to slide up with an animation as a profile loads or is selected.

Restrict Number of PRs to be displayed in the results section. Currently all the PRs are displayed however maximum 4 PRs should be displayed.

Would be nice if the image and/or link below the buttons navigated you to the github account associated

When you select a profile, it would be nice if the profiles changed with a easing so that it doesn't so clunky.

Either add a section to explain how to get started locally or link to pre-existing explanation.

GitHub has an API limit for non OAuth users--perhaps fix with client OAuth?

Save the result of the last searched user in a single browser session so that every time a person opens the extension, it is not blank and shows the results related to the last searched GitHub Handle.

Add contributors to readme file which are there in the contributors section of this repository.

When you have reached over 5 PRs for the Hacktoberfest challenge, the bar appears to use the array index to set the length.

This means the bar extends outside the extension page container.

Solution: Fix the length of the progress bar to 5 segments max.

The profile icon has been removed from below the buttons to improve the UI (#76)

Now the icons at the top are enlarged, but maybe the active profile icon should be larger than the unselected?