Add CI to run tests for PRs about hacktoberfest_progress HOT 15 OPEN

PR in :)

from hacktoberfest_progress.

Sure, will do it today itself !!

from hacktoberfest_progress.

@lmcjt37 I have synced my account with Circle CI and added this project. Let me know if anything else needs to be done.
@joseph-allen FYI.

from hacktoberfest_progress.

@adeora7 just need to add the status checks for CircleCi in the settings for this repo - https://circleci.com/docs/2.0/workflows-waiting-status/

from hacktoberfest_progress.

happy to pick this one up for you, will require some CircleCI setup your part though?

from hacktoberfest_progress.

@adeora7 If you register for CircleCI, sync your github to it and then add this repo as an app - that will allow @joseph-allen to start creating the pipeline.

from hacktoberfest_progress.

PR has been merged - pending CircleCI setup from @adeora7

from hacktoberfest_progress.

you can also change the PR settings so that passing tests are required before a merge 😈

from hacktoberfest_progress.

@joseph-allen definitely needs to be done - best to hold off until the CI is in place or nothings getting merged

from hacktoberfest_progress.

@adeora7 the checks don’t appear to be notifying github. Could you screenshot the branch checks section where you select which checks are needed for merge?

from hacktoberfest_progress.

@adeora7 also worth checking that the builds are being run in the CircleCi dashboard and succeeding

from hacktoberfest_progress.

Looking into this more, not that we should have to, but may need to add a workflow to the YAML config to maybe kick this into life

from hacktoberfest_progress.

@adeora7 Have you had chance to look into this? It's blocking all merges so I marked it as blocked

from hacktoberfest_progress.

@adeora7 Hi again. This is still and issue, would be good to either fix the CI or Github integration.

Failing that, you should disable the CI branch check so that the PRs can be approved and merged.

from hacktoberfest_progress.

@adeora7 I know how to fix this having done it recently on my own project.

CircleCI > Settings > Projects > (click cog of project) > Advanced settings > Turn "Build forked Pull Requests" on.

This will resolve the forked PRs not being picked up.

from hacktoberfest_progress.