zzawadz / customlayout Goto Github PK

We are contacting you because you are the maintainer of customLayout, which imports ggplot2 and uses vdiffr to manage visual test cases. The upcoming release of ggplot2 includes several improvements to plot rendering, including the ability to specify lineend and linejoin in geom_rect() and geom_tile(), and improved rendering of text. These improvements will result in subtle changes to your vdiffr dopplegangers when the new version is released.

Because vdiffr test cases do not run on CRAN by default, your CRAN checks will still pass. However, we suggest updating your visual test cases with the new version of ggplot2 as soon as possible to avoid confusion. You can install the development version of ggplot2 using remotes::install_github("tidyverse/ggplot2").

If you have any questions, let me know!

Hello,

Since I made changes in theme functions and default values of flextable, a test broke in customLayout (https://github.com/zzawadz/customLayout/blob/master/tests/testthat/test-flextable.R#L24). It's because:

• The padding is now 3 for the bottom, top, left, right, it was 2, 2, 5, 5,
• The default font is now chosen according to the platform and is no longer "Roboto or Arial".

Could you add testthat::skip_on_cran() to this test? Or maybe drop it. It freezes flextable to its current state. This is not a regression nor a bug, it's a change, this test should not be blocking.

KR
David

It will be better for integration with other tools like officer.

So the names like laySet will be replaced with lay_set.