Wrong outupt of Register::EFLAGS.get_largest_enclosing(zydis::MachineMode::LONG_64) about zydis-rs HOT 5 CLOSED

Yeah. I think this function is broken for any register that isn't encodable with a (register-class, register-id) tuple, so any register having a -1 in the first numeric column here: https://github.com/zyantific/zydis/blob/master/src/Generated/RegisterLookup.inc. These are all registers that can only be read and written to via specialized instructions.

@flobernd I think we should probably special case at least EFLAGS and EIP in ZydisRegisterGetLargestEnclosing: the whole "needs to be (class, ID) encodable requirement is not at all obvious from the function signature.

from zydis-rs.

We need the updated zydis-c submodule to fix this

from zydis-rs.

Not a fan of bindings where the corresponding library is pinned to some random commit. Will need to do a 4.X release of Zydis first. It's a bit more work than I'd like because there were some (minor) breaking changes on master & I'll need to start a branch that undoes those while keeping all the fixes.

from zydis-rs.

Following the corresponding Zydis release on Sunday, I just published v4.1.0-beta.1 that includes this fix.

from zydis-rs.

Update:
This is not a rust bindings bug, it's a Zydis's bug itself

from zydis-rs.