Comments (5)
th0rex
commented on June 23, 2024
1
Nice to hear that it works. For some reason I'm unable to do a release on crates.io, we'll have to wait for @athre0z to be back for that. But I hope building directly from git is good enough for now :)
from zydis-rs.
williballenthin
commented on June 23, 2024
I tried using miri to audit the unsafe code in zydis-rs, but it is unable to emulate into zydis-c and bails.
from zydis-rs.
williballenthin
commented on June 23, 2024
@th0rex tagging you since I think you originally added this code in #2 and would be familiar with the userdata casting.
from zydis-rs.
th0rex
commented on June 23, 2024
Hi, thanks for the detailed bug report!
I believe I found and fixed the problem, could you test the latest master on your side? If it's working I'll do a release on crates.io.
Thanks again for filing the bug!
from zydis-rs.
williballenthin
commented on June 23, 2024
With the changes on nightly, my test cases and external project work as expected. Thanks @th0rex!
As an aside, it took me many reads of the patch to understand where the bug was. This is why I avoid unsafe :-) I'm so used to rustc providing reliable warnings/errors that I never would have guessed about the scope issue, esp with no warnings or lint failures. Thanks again for digging in and quickly releasing a fix!
from zydis-rs.
Related Issues (17)
- Do a new release HOT 2
- Update to v2-beta HOT 2
- Version 0.0.4 not on crates.io HOT 3
- zydis-rs fails to build on windows from github HOT 2
- InstructionAttribute IS_PRIVILIGED is misspelled ("privileged") HOT 1
- BranchType serialization feature misspelled: Deserilaize HOT 1
- type mismatch for ZydisMnemonic and ZydisMnemonics HOT 4
- Tracking: Webassembly support HOT 11
- crash during instruction serialization HOT 4
- lea, "(empty)" second operand "action" HOT 3
- mismatched types on arm HOT 2
- Update to latest Zydis version HOT 17
- Wrong outupt of Register::EFLAGS.get_largest_enclosing(zydis::MachineMode::LONG_64) HOT 5
- Enhance AccessedFlags struct HOT 6
- InstructionAttributes not applied to FullInstruction HOT 2
- Windows Kernel support HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from zydis-rs.