zoriya / kyoo Goto Github PK

Describe the bug
When the user start the webapp with a direct link to the watch page, an empty page is returned with errors in the console.

To Reproduce
Steps to reproduce the behavior:

1. Get a /watch link from the web app
2. Open a new tab and use the link
3. Look at the empty page and errors in the console.

Environment:

• Platform: Any
• Version: 0221cb7 (master)

Is your feature request related to a problem? If yes, please describe.
When a show was just added to Kyoo, we might want to access it quickly to watch it

Describe the feature you'd like
From the Home Page, on the sort dropdown, add the option to sort the show by the add time (most recent first)

Describe alternatives you've considered
Having to scroll down to the said show, which is redondant when we have a massive library

Describe the feature you'd like
When editing a show's metadata, we should be able to set a poster using a local file or a URL

Describe alternatives you've considered
The workaround is to manually move the poster to Extra/poster.jpe

Describe the bug
When a video takes too long to transmux/transcode, or is not compatible with Kyoo, nothing hapens, and the user might wait.

To Reproduce
Play a heavy file, for example

Expected Behavior
When a video takes too long to transmux/transcode, or is not compatible with Kyoo, a message should warn the user.
Environment:

• Platform macOs X
• Prebuilt version from commit 'b8022a6'

Is your feature request related to a problem? If yes, please describe.
The cache is not cleared periodically

Describe the feature you'd like
An automation from Kyoo that clears the cache on a regular basis'.
Describe alternatives you've considered
rm -rf cache

Describe the bug
When we scroll down to the bottom of the page before the rest of the movie list is loaded (very quickly, like when we know what show we want), the loading is interrupted, until we scroll up a little bit.

To Reproduce
Scroll down to Kyoo's main page very quickly, before the end of the list is loaded.

Expected Behavior
We'd expect the list to load progressively, like it does when we scroll normally.

Environment:

• Platform: macOS
• Prebuilt version from commit 'b8022a6'

Is your feature request related to a problem? If yes, please describe.
I want to create a collection that does not exist on a provider, for example for concert movies.

the problem is, if the collection is not known, it doesn't create a metadata folder, and the 'Image' field in the 'Collection' table in the db is set to null. As long as it'll stay null, the metadata will not be taken into account

Describe the feature you'd like
I would like to be able to create a collection myself, by move related films to a collection folder, and give an illustration to it.

Describe alternatives you've considered
To create 'my' collection, I had to create a metadata folder, put illustrations (poster/thumbnail.jpe) and set the 'Image' field in the 'Collection' table in the db to dummy values.

Is your feature request related to a problem? If yes, please describe.
I can't stand pausing the video using the mouse to try to click the right amount of time just to get 5 or 10 seconds back in the video

Describe the feature you'd like
this -> https://support.google.com/youtube/answer/7631406?hl=en

Describe alternatives you've considered
see the feature requested section

Additional context
any YouTube video

These tasks should use new threads & not those of the thread pool because we don't want the server to stop responding to requests.

• Transcoder: System.Threading.Tasks.TaskCreationOptions has a long-running option to entirely skip TheadPools.
• Crawler & background services: Add a TaskScheduler to use another ThreadPool?

The API should set the poster, backdrop, logo and thumbnail values of Shows, Collections, Episodes and Seasons before returning them.

The front shouldn't need a getThumb function.

Currently, when kyoo can't connect to the database, the task's runner just hang and never returns. An exception should be thrown to inform the user what is wrong and the application should quit.

• Building on windows should compile the transcoder.
• Build the app and allow builds to be downloaded for linux.
• Build the app and allow builds to be downloaded for windows.
• Create a good dotnet-publish function which should replae the install.sh/Makefile.
• The dotnet-publish should create a systemd file for linux.
• The dotnet-publish should create a windows service for windows (I think).
• New versions of the common should be published to nuget automatically.

Use react instead of angular

I created a weird login system with oauth2, it should be reworked to use simple jwt instead.

The documentation should be updated too.

Describe the feature you'd like
Display the shows like a list, instead of a poster list. It is handy when we want to look for a title instead of a poster.

It could look something like this:

Is your feature request related to a problem? If yes, please describe.
When we want to use Kyoo for the first time, we don't know what to do.

Describe the feature you'd like
Add a 'Set up' section and some requirements in the main README.md

Describe alternatives you've considered
Have AnonymusRaccoon next to you

/api/genres/aùlkgnalgn/shows -> 404 (GOOD)
/api/shows/zjengeng/genres -> 200 [] (BAD)

Describe the feature you'd like
Users should be able to configure Kyoo with a nice UI instead of having to change the settings.json file and doing curls to add libraries.

Describe alternatives you've considered
Edit the settings and follow the SettingUp section.

Describe the bug

GET /api/show?people=agnes-b results in a 500. The ApiHelper convert this to an expression with DbSet<Show>().Where(x => x.People.Any(y => y.Slug == "agnes-b")) but the Slug property does not exist for PeopleRole on the database.

Environment:

• Platform: X
• Action Version: f4ba5c5
• Database: Postgres (& SqLite i believe)

Is your feature request related to a problem? If yes, please describe.
When a show contains subtitles tracks, their appear in Kyoo's play screen's subtitle popup.
If the track is not supported (ie is a bitmap subtitle format), the option is greyed.

When none of the track is supported, they are all in grey, and we don't know they are disabled

Describe the feature you'd like
If a subtitle track is not supported, it should be written. Like "Unsupported"

Describe the bug
When we want to change a movie's metadata using a film's ID from a metadata provider, an error message pops up, and the metadata is not changed.

To Reproduce
Steps to reproduce the behavior:

1. From a movie's page, click 'Edit metadata' in the popup menu
2. Scroll down to section 'Search on metadata providers'
3. Set the move's id to the correct one
4. the error pops up

Expected Behavior
We expect the metadata form to close, and the movie's page to be refreshed, displaying the correct info.

Environment:

• Platform : macOS X
• Prebuilt version, from commit 'b8022a6'

The api has the same data type for movies and shows and uses the bool isMovie to distinguish the two, this is kinda awkward,

The login page should be responsive.

Describe the bug
When a show has a title with a special character in it (for example 'é', 'à', 'ç', ...), even if it matches the metadata provider, the metadata is not added in Kyoo

To Reproduce
Have a movie titled 'Asterix & Obelix Mission Cléopâtre'

Expected Behavior
We'd expect the metadata to be shown in Kyoo

Environment:

• Platform: mac Os X
• Prebuilt version from commit 'b8022a6'

Since the m3u8 files are being written to by the transcoder, asp.net's default FileResult tries to write more byte into the request than what has been written on the header. We should prevent this by limiting the amount of byte (or lines) written.

Is your feature request related to a problem? If yes, please describe.
In the case where a library is stored on an external drive, when that drive is unavailable, the housekeeping task considers the files do not exists anymore, therefore, the db is flushed.

Describe the feature you'd like
There should be a guard in the housekeeping task, keeping the task from deleting everything if none of the file in the library is found.

Describe alternatives you've considered
This problem happended to me several times, thank the lord of Kyoo, I work in a macOs with Timemachine enabled and a backup drive plugged in at all time. I could resotre the db to a previous state.

Additional context
The practical case is the following: I have a service that executes Kyoo at startup, but my Drive takes time to be recognised by my machine. Therefore, if Kyoo is initialized before my Drive, the db is flushed, and at the next scan, the whole library will be rescanned

Describe the feature you'd like
On show scan, just like it does with subtitles, export posters embedded in file

Describe alternatives you've considered
Using ffmpeg to export each poster manually

Additional context
With iTunes, the posters are not stored in a seperate jpg file, it embeds the poster within the file

https://wiki.archlinux.org/index.php/Creating_packages

https://wiki.archlinux.org/index.php/AUR_submission_guidelines

Clean up the relative/absolute path inconsistency
Fix the epiosde detection from the path, allow filename or slug detection

Meta issue that should regroup

• Playback information (when the user start playing, pausing, pings with the timer...)
• Tasks information (one started, queued, finished, error...)
• CUD (of any resource)

Save shows watched by the user.

Describe the bug
Currently the output of ffmpeg is considered trustworthy, if the value of language is unknown instead of the standard unk it breaks

To Reproduce
Simply have a track with unknown instead of unk and see the Track's internal slug setter throw on database reads.

Describe the bug
When there is a hidden file in a show's folder (maybe a temporary file, like .DS_STORE, or ._my_movie.ext), it should not be scanned by default.

To Reproduce
Touch a file ._movie.ext in movie/

Expected Behavior
We don't want to see the trace of a hidden file's scan in the log

Environment:

• Platform: macOs
• Prebuilt version from commit 'b8022a6'

Describe the bug
In some cases, movies in a collections may not appear like they belong to it.

The cases were it works or don't are not known

To Reproduce
Steps to reproduce the behavior:

1. Move all film folders in a collection folder (for example: 'Harry Potter 4' in 'Harry Potter')

Expected Behavior
We expect all the films to be in the said collection

Environment:

• Platform macOs
• Prebuilt version from commit 'b8022a6'

Describe the feature you'd like
On a show's page, display the video's playtime

Describe alternatives you've considered
Cringe

Describe the bug
On a show's page, the staff's list displays the members orders by name, in alphabetical order.

To Reproduce
Steps to reproduce the behavior:

1. On a show's page
2. Scroll down to the 'Staff' section

Expected Behavior
We'd expect the main actors or the main movie makers to be displayed first, then supporting actors, etc.
for example: in the movie 'sister act', we'd expect Whoopi Goldberg to be seen first. Since her name starts with a 'W', we don't even see her in the list.

Environment:

• Platform: macOs X
• Prebuilt version from commit 'b8022a6'

Describe the bug
When playing a movie without any audio track (only a video one), the web-app bugs and the player page can't be rendered.

Describe the feature you'd like
On a collection's page, we would like to see an overview text and it's banner/thumbnail. The overview is stored in the database, but is not used.

Describe the feature you'd like
From User interface, we should be able to execute a scan or housekeeping task

Describe alternatives you've considered
Going to '/api/task/housekeeping' and '/api/task/scan'

Additional context
Handy when a movie was just added, and we want it to be shown in Kyoo

Is your feature request related to a problem? If yes, please describe.
The movie 'The Purge' is titled 'American Nightmare' in Europe.
Therefore, having the movie 'American Nightmare' fetch the metadata from another film with the same title, completely unrelated.

Describe the feature you'd like
Somewhere, maybe in the settings.json, be able to set the language used to fetch data from the metadata provider

Describe alternatives you've considered
Rename the movie in the OG language

Is your feature request related to a problem? If yes, please describe.
When we want to download a whole season, we have to download individually each episode. It becomes repetitive with seasons including 10+ episodes

Describe the feature you'd like
Adding a download button that creates an archive of the episodes and downloads it

Describe alternatives you've considered
Download each episode individually

Is your feature request related to a problem? If yes, please describe.
Being a Plex user, we use to see a score near the metadata provider logo on a Show's page. In Kyoo, the logo is a button, and we don't it is one until we click it (if we ever click it)

Describe the feature you'd like
Change layout to make the logos appear more like buttons than simple, non interactive images.

Additional context
This is from a Plex user, maybe a non-user sees it a different way?

Maybe check if appsettings.jsok exists in the current repo and if it doesn't copy it from the binary directory?