zold-io / java-api Goto Github PK

There is a lot of use of Mockito in the tests, it makes it very hard to read and a pain to write.

Using Fakes (see https://www.yegor256.com/2014/09/23/built-in-fake-objects.html) instead would improve the quality of the tests as well as provide a secondary implementation of the main concepts of the Zold java-api, which can only be good for the project.

The Network interface should contain method, that will allow pulling all wallets.

public interface Network {
    // Pull all wallets from the network.
    Wallets wallets();
}

The puzzle 40-432fb579 from #40 has to be resolved:

The puzzle was created by Victor Noël on 28-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 29-4f17ced3 from #29 has to be resolved:

The puzzle was created by Victor Noël on 25-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 61-7c0a7e0c from #61 has to be resolved:

The puzzle was created by rultor on 04-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

We have code duplication in RtTransaction. Each method parses transaction string in a same manner:

final String value = new UncheckedText(
    new IoCheckedScalar<>(
        new ItemAt<>(
            index, new SplitText(this.transaction, ";")
        )
    ).value()
).asString();

We can extract this to a method or a class.
Furthermore we can simplify the above example to:

final String ident = new IoCheckedScalar<>(
    () -> new ItemAt<>(0, new SplitText(this.transaction, ";"))
        .value().asString()
).value();

The puzzle 12-1be65647 from #12 has to be resolved:

The puzzle was created by rultor on 08-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-f9a60893 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The README.md is outdated. There is no find method in Wallets. Also no pull method in Wallet. The Amount interface does not exist.

With outdated documentation, it's hard to understand how the interfaces are intended to be used.

The puzzle 21-829d3247 from #21 has to be resolved:

The puzzle was created by Paulo Lobo on 13-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

In the process of solving #40, I am faced with a problem with the existing code.

The javadoc of Network.push says:

    /**
     * Push the wallet to the network. The network will select the
     * remote node with the highest score (with a minimum of {@code 16}).
     * @param wallet The wallet
     */
    void push(Wallet wallet);

But I don't think that is correct: the papers talks about selecting nodes with high score and a minimum of 16 when paying taxes. This has nothing to do with pushing, which should be done to every known nodes (even though they can decide not to accept the wallet).

The concept of paying taxes and of pushing should be separated (it is the case in the ruby implementation).

Either Wallet should be responsible of paying taxes, or Network should.

I would be favour of letting Network do that simply because it would be best, design-wise, to have Wallet being ignorant of Network and Remotes matters. Network already manipulates both Remotes and Wallets.

@llorllale what do you think?

@paulodamaso since you did create the @todos I suppose you have maybe an opinion?

New qulice version brings following important changes:

• removal of @author tag (it is prohibited now)
• removal of @version tag (it is prohibited now)
• license header should start with /* instead of /** - this will fix problem with IntelliJ reporting it as a javadoc that is not attached to any class
• checkstyle validation performance improvement (speedup of ~ 10%)
• few minor formatting changes.
  Please upgrade the qulice and fix the new problems found. It would be a good idea to upgrade now that the codebase have just a few classes.

The puzzle 16-27c16652 from #16 has to be resolved:

The puzzle was created by rultor on 12-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Current implementation of RtTransaction.hashCode directly delegate to this.transaction.hashCode, but this breaks the contract of Object that says that equals and hashCode should be coherent together.

In particular it means that a transaction and a plain string can have the same hash code, but calling equals on them will return false.

The solution is trivial: use Objects.hash that ensure this does not happen.

The puzzle 12-99ac50e5 from #12 has to be resolved:

The puzzle was created by rultor on 08-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 54-605ff193 from #54 has to be resolved:

The puzzle was created by rultor on 11-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-af7c6ffd from #6 has to be resolved:

The puzzle was created by rultor on 04-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

It will be useful for tests to have class WalletMatcher. It can be used as follows:

MatcherAssert.assertThat(
    new WalletsIn(this.path).create(),
    WalletMatcher.hasId(id)
);

The puzzle 54-c02fec87 from #54 has to be resolved:

The puzzle was created by rultor on 11-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-4f67a35d from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

On running maven clean install -Pqulice throw the following error on Windows:

Failed to execute goal org.apache.maven.plugins:maven-antrun-plugin:1.8:run (default) on project java-api: An Ant BuildException has occured: Execute failed: java.io.IOException: Cannot run program "xcop": CreateProcess error=2,
[ERROR] around Ant part ...... @ 18:50 in C:\zold\java-api\target\antrun\build-main.xml

For com.jcabi required to install xcop by gem and add to PATH variable.

The puzzle 15-ad2b4fa5 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The Wallets interface has a method to create a new Wallet instance. In order to create Wallet we need header information:

• wallet id
• network name
• protocol version
• public RSA key.

I'm not sure, that the Wallets.create() should accept that information through parameters. Who should maintain the ids? From where we will receive it? Through the constructor of WalletsIn()?

The puzzle 4-aab61a84 from #4 has to be resolved:

The puzzle was created by Tolegen Izbassar on 03-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's implement Wallets:

Let's name the implementation WalletsIn.

Let's implement Wallet:

According to the white paper, we should sign each transaction with RSA. For that, we need an RSA private key. Where to get it? Will it be generated for each wallet?

The puzzle 16-e32ec38b from #16 has to be resolved:

The puzzle was created by rultor on 12-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 5-dec07794 from #5 has to be resolved:

The puzzle was created by Paulo Lobo on 19-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 4-968ad704 from #4 has to be resolved:

The puzzle was created by Tolegen Izbassar on 03-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 6-f97f5c14 from #6 has to be resolved:

The puzzle was created by rultor on 04-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's create a skeleton and deploy it to Maven Central.

According to the whitepaper merging of two wallets is an operation of merging copies into a local one.
Merge algorithm first sorts the copies and then merges transactions from that copies.
Currently, sorting is done outside Wallet.merge() method. It is part of Remote.pull() method.
I propose to add an additional method to Wallet : Wallet merge(Copies copies) and remove explicit sorting from Remote.pull().
Similar to what we have in ruby version

The puzzle 15-0d2d728d from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 5-c56bb757 from #5 has to be resolved:

The puzzle was created by Paulo Lobo on 19-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-1e017e66 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 56-e2c92447 from #56 has to be resolved:

The puzzle was created by Vatavuk on 14-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-0b8da355 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 33-65714492 from #33 has to be resolved:

The puzzle was created by George Aristy on 12-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 41-44da2a34 from #41 has to be resolved:

The puzzle was created by Victor Noël on 23-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-a01f2b41 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

Let's implement Network:

It's not clear how to connect to Zold network. Is there some REST API that we should use? Or there is some master address, and we need to issue some commands?

The puzzle 6-2cc9aa8f from #6 has to be resolved:

The puzzle was created by rultor on 04-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 56-02b4f5e6 from #56 has to be resolved:

The puzzle was created by Vatavuk on 06-Aug-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-b88242e3 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 5-38f68f69 from #5 has to be resolved:

The puzzle was created by Paulo Lobo on 19-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 15-957c2199 from #15 has to be resolved:

The puzzle was created by Tolegen Izbassar on 06-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 61-94b7f6ca from #61 has to be resolved:

The puzzle was created by rultor on 04-Dec-18.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.

The puzzle 5-fd3c6d54 from #5 has to be resolved:

The puzzle was created by Paulo Lobo on 19-Jul-18.

Estimate: 30 minutes,

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.