Git Product home page Git Product logo

kspserialio's People

Contributors

gerakuznetsov avatar phardy avatar zitron-git avatar

Stargazers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

Watchers

 avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar  avatar

kspserialio's Issues

[1.1] Stage counts incorrect

CurrentStage and TotalStage are always calculated to be 0 and 1 respectively, no matter what vessel is loaded.

ControlPacket.mode

ControlPacket.mode doesn't seem to work.

Looking through code, I cant find a reference where it is used.

small inconsistencies in VesselData members

yikes the issue ran away before I finished typing...

Various of the VesselData members store values represented in seconds. Unfortunately they use various data formats:

  • TAp (long)
  • TPe (long)
  • period (long)
  • MissionTime (UInt32)
  • deltaTime (float) - I understand the need for this one to be different
  • MNTime (UInt32)

While it's not a big deal it makes writing a function that converts seconds to a readable time format (array-of-char) a bit more cumbersome. Maybe you could change that in a future version.

Time Warp on KSP speeds also up the serial communication speed

Whenever using the Time Warp feature to speed up the time in KSP, the plugin would also speed up the serial refresh rate (i.e on 2x time warp the plugin would send the data twice as fast).

It might have something to do with by using Unity's Time.time (which is scalable by Time.timeScale) instead of i.e Time.realtimeSinceStartup.

if ((Time.time - lastUpdate) > refreshrate && KSPSerialPort.Port.IsOpen)
{
lastUpdate = Time.time;

Time-realtimeSinceStartup

VesselData.MNDeltaV

The VesselData.MNDeltaV member displays the total amount of deltaV required for a maneuver node.

Is this on purpose? I believe remaining deltaV for a maneuver node will be much more useful.

In relation to that, there doesn't seem to be a member "MNDuration" or something like that which contains the seconds required to execute a maneuver node. Is something like that planned?

Ingame and button inputs

If I clic on the RCS ingame button, it turns on of course, but then I can no longer use the arduino button to turn it on/off. And if I clic on it again, it turns off, and then I can use the arduino button again to control it.

Made a short video to show you what it does : https://www.youtube.com/watch?v=K3OvMLiDWco

I think this comes from the following lines (starting at 1081) :

if (KSPSerialPort.VControls.RCS != KSPSerialPort.VControlsOld.RCS) { ActiveVessel.ActionGroups.SetGroup(KSPActionGroup.RCS, KSPSerialPort.VControls.RCS); KSPSerialPort.VControlsOld.RCS = KSPSerialPort.VControls.RCS; //ScreenMessages.PostScreenMessage("RCS: " + KSPSerialPort.VControls.RCS.ToString(), 10f, KSPIOScreenStyle); }

Breakout Serial Code

Hi,

This plugin looks amazing! Can you break out the Serial code into a interface so I can attempt rigging a *nix compatible serial controller?

/K

how to install?

It is not clear to me how to install this mod and there doesn't seem to be any documentation

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    ๐Ÿ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. ๐Ÿ“Š๐Ÿ“ˆ๐ŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google โค๏ธ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.