Git Product home page Git Product logo

Comments (6)

ziadevcom avatar ziadevcom commented on May 30, 2024

What about we just remove padding with 0 from hours and decrease the font size by few pixels?

This is how it looks with font size of 2.2rem and removed leading 0.

image

image

from pomatez.

roldanjr avatar roldanjr commented on May 30, 2024

It seems a little bit off for me @ziadevcom can we make support 90 minutes instead of 120 minutes @sekwah41 ?

from pomatez.

sekwah41 avatar sekwah41 commented on May 30, 2024

The thing is this was requested as a 120 min limit from a user. We should probably try to accommodate that.

Tbh as long as it mostly looks fine it's a very edge case of users that'll want to go that long.

I think we are better off accommodating as many people as possible rather and making it slightly odd only when that edge case is used. I've not had a lot of time lately to tinker sadly though I can try to take a look at this if I get to it before anyone else.

from pomatez.

ziadevcom avatar ziadevcom commented on May 30, 2024

Hey @sekwah41

I agree with you, in fact, if you look at my previous message above. You can see i did some tinkering with CSS and made it look ok.

In fact we can improve it little more by reducing the size of some other ui elements in compact mode.

from pomatez.

roldanjr avatar roldanjr commented on May 30, 2024

Yes, you have a point @sekwah41, it's an edge case. Just create another PR @ziadevcom that fixes this issue :)

from pomatez.

ziadevcom avatar ziadevcom commented on May 30, 2024

I am sorry for not following up on this but I will, hopefully, work on this tomorrow.

from pomatez.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.