Suggestion: Ability to set longer focus time than 60 minutes about pomatez HOT 14 CLOSED

yep we accept PR's :) @ziadevcom

from pomatez.

I see you are studying React and stream programming. Ill try to give you as much feedback as possible if I request changes 😄

from pomatez.

I am willing to fix this. Do you guys accept pull requests? I am sorry if this is not the right place to ask this.

from pomatez.

We can set the maximum focus time to 120 minutes but I have a question.
Should we keep the unit still in minutes? or we can change it to hours after 59 minutes?
In my opinion, it would be better keeping it minutes. It's a simpler approach and it does not really hurt UX.
What do you think?

from pomatez.

I think either one works, though changing the view to say 02:00:00 rather than 120:00 may be a bit strange. While it makes more sense based off how most time stuff displays, having it vanish once it goes sub 60 mins would be stranger.

from pomatez.

I have decided to go with default format of 120 minutes. I think that works just fine.

from pomatez.

Actually, ive just made some css changes and it doesn't look that bad if we toggled it via the max time

Basically, disable the grid display, remove grid-template-columns and text-align:center and its sorted.

As long as we reduce the margins between the span's which is what that does, though to keep the original look wed need to also optionally toggle some margin spacing depending on which one is being displayed.

from pomatez.

I would personally prefer it like this, though @roldanjr is the main design guy on this :)

from pomatez.

Right, I will take a look at the timer component and understand how it works. I will get back to you soon.

from pomatez.

Feel free to ask any questions or let me know if you need a hand; the only reason I haven't implemented this yet was I've just been quite pre-occupied with other projects and haven't got around to it :) So it really helps with others come along to lend a hand ^.^

from pomatez.

Thank you, this won't be easy for me considering this is my first time contributing to open source but I am up for a challenge.

from pomatez.

I wanted to confirm but we still want to keep the unit in minutes on the config screen. right?

from pomatez.

I wanted to confirm but we still want to keep the unit in minutes on the config screen. right?

Yes @ziadevcom just keep it in minutes unit :)

from pomatez.

Actually, ive just made some css changes and it doesn't look that bad if we toggled it via the max time

Basically, disable the grid display, remove grid-template-columns and text-align:center and its sorted.

As long as we reduce the margins between the span's which is what that does, though to keep the original look wed need to also optionally toggle some margin spacing depending on which one is being displayed.

I'm okay with this @sekwah41, I'll figure out next time in v2 how to address the design for this scenario.

from pomatez.