zhuyifei1999 / ishoal Goto Github PK

(ping @ionizer999)

So recently we are observing some intermittent connection failures, and I asked one whom I had connection failures with to do some testing, and we were able to reproduce it while capturing the packets by wireshark. We avoided all possibilities of having a IP collision by NAT-ing to a 192.168.99.* at ishoal, and there's what we have, with the view of the capture limited to 192.168.99.* subnet (compressed to zip because of github):

The host (them) at 192.168.99.222: a1s.pcapng.zip
The client (me) at 192.168.99.123: m1s.pcapng.zip

AFAICT, there is no packet loss or any shenanigans, but I did get the error of one or more consoles not responding, and I can't see what it is complaining about. Any ideas?

Support multiple switches - this basically needs the PBF code to be inserted twice for different IP -> MAC combinations.

Also the Switch detection code needs to be extended to support that.

While rooms (#2) will allow to easily detect conflicts of other players, there is still the problem with local device conflicts.

Those can be solved by checking whenever a node joins if any other node in the network would get a local reply on that IP address.

There are 2 cases:

• Node joins newly and has the same IP as some device in someone else's subnet
• Node joins newly and a device in the network has the same IP as one of the existing IPs already

A larger problem however are devices that are added to the network dynamically as one would need to constantly check for ARP packets.

=> Maybe router method with e.g. 17.99.. or 192.168.99.* subnet might be better. (though things worked amazingly well even though conflict area is high)

Currently when a game is going on Switches that see that, will not broadcast any information.

That makes it impossible to start a new game.

The simplest solution is to just join a room with a name (that also poses as a password).

A more comfortable solution could be to create a "Rooms" submenu and allow to join Rooms from there, marking them as locked and using color for available rooms:

- @999ers
- FreeToPlay

[Join Room] [Create Room] [Back]

But the room names would be easy to start.

Joining a room explicitly has the advantage of checking for IP conflicts before a Node joins the Room virtual network.