zhiwei2017 / named_enum Goto Github PK

RIght now there are doctests for each function.

However, that's not enough, unit tests using pytest framework are requisite for next release.

This code:

https://github.com/KnightConan/named_enum/blob/f170041b72dc93e2c6dfa28ffa3f6853ea5ad50a/named_enum/__init__.py#L118

is following Python 3.7:

https://github.com/python/cpython/blob/041bfafeb00b0e5e565986b01c00bf9cddce3b4c/Lib/enum.py#L135

while in Python3.8, it should be:

metacls._get_mixins_(cls, bases)

ExtendedEnum: In the software development, the normal Enum class is really oft extended with some extra common used functions to simplify its usages

LabeledEnum: the labeled enumeration contains normally 2 attributes: key and label, it's used to generate the choices for a dropdown.

The bot created this issue to inform you that pyup.io has been set up on this repo.
Once you have closed it, the bot will open pull requests for updates as soon as they are available.

The source code documentation needs to be enhanced with multiple usage examples

With python 3.11 we have the following error

File "named_enum/test.py", line 7, in <module>
    class NBALegendary(LabeledEnum):
  File "named_enum/named_enum/meta.py", line 152, in __new__
    namespace._convert(_tuple_cls)
  File "named_enum/named_enum/meta.py", line 75, in _convert
    self[name] = _last_values[i]
    ~~~~^^^^^^
  File "named_enum/meta.py", line 33, in __setitem__
    super().__setitem__(key, value)
  File "/usr/lib/python3.11/enum.py", line 449, in __setitem__
    self._member_names[key] = None
    ~~~~~~~~~~~~~~~~~~^^^^^
TypeError: list indices must be integers or slices, not str

Same script in python 3.10 seems to work fine

Background

Currently a lot of tests have repeated some code blocks. To avoid the duplication and centralisation the tests, it's good to clean the tests.

Solution

1. Create an abstract test class to hold the common used test functions as much as possible
2. Each individual test class inherits from this abstract class and execute all the tests with its own inputs.