Comments (2)
The code would technically work with 126, but because each meshlet aligns the index data by 4 bytes for performance, using values that aren't divisible by 4 is dangerous as they complicate the computation for worst case index buffer size and the caller might not correctly perform this; for example, for max_triangles 126, the worst case effective amount of index data per meshlet is not 126*3=378 bytes - it's 380 bytes. If the caller allocates 378 bytes per meshlet, degenerate inputs may result in an overflow of that buffer.
This limitation could of course be removed - it's just the assertion that fails; the documentation could be adjusted to reflect this (the documentation doesn't seem to mention this restriction so it needs to be updated either way...). However, in practice I think you should not observe performance degradation between 126 and the next lowest value divisible by 4 (124) because with a configuration that NVidia recommends (64v 126t), meshlets should almost never reach 124 triangles because of topology constraints.
from meshoptimizer.
Thanks for the explanation. An update in the README might be enough then.
from meshoptimizer.
Related Issues (20)
- gltfpack: Material Kd is not making it into baseColorFactor HOT 6
- Point cloud meshlet generation HOT 2
- Add soversion to shared library HOT 1
- gltfpack: Objects with large scales distort other objects' geometry HOT 3
- Error: Cannot load ...glb, buffer too short HOT 5
- ADD Merge Materials HOT 2
- gltfpack: Simplification take in account the vertex color HOT 2
- Verify the triangles are not intersecting each others when simplifying HOT 1
- Avoid hole creation HOT 4
- Simplify error calculation question / issue HOT 5
- GltfPack isnt preserving identical node hierarchy with -kn -km flags activated HOT 1
- Simplification should prefer more uniformly tessellated meshes HOT 6
- Custom attributes ( for example IDs) HOT 1
- Documentation direction Encoder User Guide HOT 3
- gltfpack: Tangent quantization is capped at 8 bits HOT 1
- gltfpack: Output GLTF is invalid if input scene has missing image files HOT 5
- gltfpack: Keep image names and unused named images HOT 1
- gltfpack: Keep `EXT_mesh_gpu_instancing`
- Simplification produces reversed faces HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from meshoptimizer.