Git Product home page Git Product logo

Comments (12)

BenjaminHae avatar BenjaminHae commented on July 17, 2024

I looked into it a while ago, the problem is, that after the alert the whole page is reloaded, so it's not that easy to implement.
It would be better practice to just reload the table and tags after editing/adding/deleting an account - then showing a notification instead of an alert would be trivial.

from password-manager.

zeruniverse avatar zeruniverse commented on July 17, 2024

We can use Ajax. That is, put all dynamic contents in a seperate php file.
But yes, it's not a trivial work.

On Thursday, 16 June 2016, Benjamin HΓ€ublein [email protected]
wrote:

I looked into it a while ago, the problem is, that after the alert the
whole page is reloaded, so it's not that easy to implement.
It would be better practice to just reload the table and tags after
editing/adding/deleting an account - then showing a notification instead of
an alert would be trivial.

β€”
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#55 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNAuHbgmJ733eUbyY7Hrebkdpj4Tuks5qMUIqgaJpZM4I2Zb3
.

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

Well For me the messages are not needed anyway. Can't you just disable them?

from password-manager.

zeruniverse avatar zeruniverse commented on July 17, 2024

Temp solution for you: open password.php using notepad, search for 'alert'
and delete all of them.

On Thursday, 16 June 2016, Nick [email protected] wrote:

Well For me the messages are not needed anyway. Can't you just disable
them?

β€”
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#55 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AEbvNI3uS6nV9WhsqCMRc-2YXX03-Uiiks5qMfgLgaJpZM4I2Zb3
.

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

Yeah I already did this for now.
Just thought this is a general improvement that I should report.

from password-manager.

BenjaminHae avatar BenjaminHae commented on July 17, 2024

I'll give it a try.

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

Thanks Benjamin πŸ‘

from password-manager.

BenjaminHae avatar BenjaminHae commented on July 17, 2024

@nickbe I think I've got it, but as this is a major change I'd be glad if you tested it before I'll merge it to the master branch. You just need the files src/password_ajax.php and src/password.php from my development branch

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

I'll test this later today and report the results to you.

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

There seems to be a problem with refreshing the view after deleteing an entry.
Entry is still visible and can be even openend, but after F5 it's gone.

Otherwise the messages look really fine this way.

from password-manager.

BenjaminHae avatar BenjaminHae commented on July 17, 2024

@nickbe thanks. It should work now. I just pulled everything to master.

from password-manager.

nickbe avatar nickbe commented on July 17, 2024

Will update the live system tonight.
Thanks!!!

from password-manager.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    πŸ–– Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. πŸ“ŠπŸ“ˆπŸŽ‰

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❀️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.