Comments (5)
There'll be tons of cases that user can make this fields broken. I think as
long as it can be JSON.parse(), we can take it.
For linebreak, I'll remove the new line or space at the end or beginning.
On Thursday, 17 March 2016, Benjamin Häublein [email protected]
wrote:
If you insert a linebreak when customizing fields the javascript code
can't be executed because there will be a linebreak in a string literal.—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#23
from password-manager.
Problem is: If you change fields to contain a linebreak, everything is broken. You can't access your account and change it back.
from password-manager.
I realized it. I think just need to remove all spaces and new lines at the
beginning or end.
Is it right?
On Thursday, 17 March 2016, Benjamin Häublein [email protected]
wrote:
Problem is: If you change fields to contain a linebreak, everything is
broken. You can't access your account and change it back.—
You are receiving this because you commented.
Reply to this email directly or view it on GitHub
#23 (comment)
from password-manager.
The way I would prefer is removing the linebreaks when reading the fields from the database. But only the first time, not when reading them for the textarea. That way the user may format it nicely.
from password-manager.
Fixed by 5fbe322
from password-manager.
Related Issues (20)
- Enable Group by Tags default HOT 2
- sort by name HOT 2
- random_login_stamp HOT 7
- Positive comment and thank you HOT 3
- Extra table td before username HOT 6
- Import problem with Username filed HOT 1
- Is this still active and mainteined? HOT 6
- Complete rework HOT 1
- Import CSV failed. HOT 4
- Replace SHA512 with SHA3-512 HOT 3
- Move to maintainance mode HOT 2
- Upgrade plugin to support v11.00 HOT 4
- PIN doesn't work on newest version HOT 5
- Cannot read property 'importKey' of undefined HOT 2
- TypeError: Cannot convert undefined or null to object AFTER LOGIN HOT 4
- New Implementation is ready HOT 1
- what is the password HOT 6
- Cannot run version 11: error 'sorry-update-your-browser' or am I not meeting the minimum requirements? HOT 1
- Can no longer copy password to clipboard without revealing it? HOT 2
- Current web browser doesn't support the technologies in Android 8.1 HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from password-manager.